Page MenuHomePhabricator
Differential D15400

[ecashaddrjs] Add types so typescript apps can import without having to declare
ClosedPublic
Actions

Authored by bytesofman on Feb 6 2024, 17:42.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC28e5e8b2336c: [ecashaddrjs] Add types so typescript apps can import without having to declare
Summary

Depends on D15399

Add types declaration file and bundle with module so that typescript apps may use ecashaddrjs without having to declare its types.

Test Plan

See draft diff D15392, where this diff's version of ecashaddrjs has been installed, and CI build now passes.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecashaddrjs-fixes
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26973
Build 53512: Build Diffecashaddrjs-tests
Build 53511: arc lint + arc unit

Event Timeline

bytesofman created this revision.Feb 6 2024, 17:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 6 2024, 17:42
bytesofman published this revision for review.Feb 6 2024, 17:43
Harbormaster completed remote builds in B26969: Diff 45019.Feb 6 2024, 17:44
bytesofman updated this revision to Diff 45023.Feb 6 2024, 20:22

use npm version patch to bump version

Harbormaster completed remote builds in B26973: Diff 45023.Feb 6 2024, 20:23
bytesofman edited the test plan for this revision. (Show Details)Feb 6 2024, 20:26
PiRK accepted this revision.Feb 7 2024, 08:59
This revision is now accepted and ready to land.Feb 7 2024, 08:59
Closed by commit rABC28e5e8b2336c: [ecashaddrjs] Add types so typescript apps can import without having to declare (authored by bytesofman). · Explain WhyFeb 7 2024, 10:27
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC28e5e8b2336c: [ecashaddrjs] Add types so typescript apps can import without having to declare.
bytesofman mentioned this in D16337: [ecashaddrjs] Fix change log section of README.Mon, Jun 17, 10:29
bytesofman mentioned this in rABCd43ea4a3c8e6: [ecashaddrjs] Fix change log section of README.Mon, Jun 17, 19:09

Revision Contents
Changeset List

PathSize
modules/
ecashaddrjs/
1 line
4 lines
3 lines
src/
41 lines

Diff 45023

View Options

modules/ecashaddrjs/README.md

Loading...
View Options

modules/ecashaddrjs/package-lock.json

Loading...
View Options

modules/ecashaddrjs/package.json

Loading...
View Options

modules/ecashaddrjs/src/cashaddr.d.ts

Loading...