[Chronik] Move `chronik-plugin` to `chronik-plugin-impl`, add `chronik-plugin` multiplex crate
ClosedPublic
Actions

Authored by tobias_ruck on Feb 6 2024, 09:48.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCaec998047ccf: [Chronik] Move `chronik-plugin` to `chronik-plugin-impl`, add `chronik-plugin`…

Summary

Currently, using chronik-plugin in the indexer is a bit tedious, as everything has to be #[cfg(feature = "plugins")] gated, which is hard to maintain.

Instead, we move the current chronik-plugin to chronik-plugin-impl, which is then re-exported in a new chronik-plugin crate if the plugins feature is enabled, and otherwise it exports fallback structs.

Depends on D15394.

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tobias_ruck created this revision.Feb 6 2024, 09:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 6 2024, 09:48

tobias_ruck requested review of this revision.Feb 6 2024, 09:48

Harbormaster completed remote builds in B26955: Diff 45001.Feb 6 2024, 09:52

Build Bitcoin ABC Diffs / Diff Testing (chronik-client-integration-tests) failed.

Failed tests logs:

====== Get blocktxs and tx: "before each" hook for "After some txs have been broadcast".Get blocktxs and tx "before each" hook for "After some txs have been broadcast" ======
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/work/modules/chronik-client/test/integration/blocktxs_and_tx_and_rawtx.ts)
    at listOnTimeout (node:internal/timers:559:17)
    at processTimers (node:internal/timers:502:7)

Each failure log is accessible here:
Get blocktxs and tx: "before each" hook for "After some txs have been broadcast".Get blocktxs and tx "before each" hook for "After some txs have been broadcast"

tobias_ruck mentioned this in D15184: [Chronik] Plugins: Index outputs and return from protobuf.Feb 6 2024, 11:38

Fabien accepted this revision.Feb 12 2024, 11:28

This revision is now accepted and ready to land.Feb 12 2024, 11:28

Closed by commit rABCaec998047ccf: [Chronik] Move `chronik-plugin` to `chronik-plugin-impl`, add `chronik-plugin`… (authored by tobias_ruck). · Explain WhyFeb 12 2024, 12:43

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABCaec998047ccf: [Chronik] Move `chronik-plugin` to `chronik-plugin-impl`, add `chronik-plugin`….