Page MenuHomePhabricator

dependencies: pinpoint lief version in install-dependencies-bullseye.sh
ClosedPublic

Authored by PiRK on Feb 13 2024, 11:16.

Details

Summary

lief 0.14.x was released earlier this year with breaking API changes.
The version is pinpointed for gitian and guix.

See https://lief-project.github.io/doc/latest/changelog.html#january-20-2024

Abstraction:

LIEF::EXE_FORMATS is now scoped in LIEF::Binary::FORMATS
Test Plan
pip install lief==0.13.2
contrib/devtools/test-symbol-check.py

Check for the absence of the error message AttributeError: module 'lief' has no attribute 'EXE_FORMATS'

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pinpoint_lief
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27100
Build 53766: Build Diff
Build 53765: arc lint + arc unit

Event Timeline

PiRK requested review of this revision.Feb 13 2024, 11:16
PiRK retitled this revision from dependencies: pinpoint lief version to dependencies: pinpoint lief version in install-dependencies-bullseye.sh.Feb 13 2024, 11:19
PiRK edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Feb 13 2024, 11:21