Page MenuHomePhabricator

[lint] fix a typehint to keep supporting python 3.8 for linters
AbandonedPublic

Authored by PiRK on Feb 18 2024, 08:19.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

We officialy no longer support python < 3.9 as of D15373, but this fix is a low hanging fruit to allow non-python devs to keep running arc lint without updating python for a little while longer.

See https://docs.python.org/3/library/re.html#re.Match

Changed in version 3.9: re.Match supports [] to indicate a Unicode (str) or bytes match. See Generic Alias Type.

Test Plan
pyenv shell 3.7.0
python test/lint/lint-files.py

Event Timeline

PiRK requested review of this revision.Feb 18 2024, 08:19
Fabien requested changes to this revision.Feb 18 2024, 11:05
Fabien added a subscriber: Fabien.

devs will not be able to build anyway as the build system requires 3.9

This revision now requires changes to proceed.Feb 18 2024, 11:05