Page MenuHomePhabricator

[qa] add cashaddr module, and fix send_big_transactions
ClosedPublic

Authored by schancel on Aug 9 2018, 17:49.

Details

Summary

Previously, send_big_transactions sent the coins to OP_TRUE.
However, this means the coins did not show up in listunspent.
As a result, several tests are unable to transition to using
send_big_transcations over create_lots_of_big_transactions.

Test Plan

./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cashaddr-qa
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3060
Build 4208: Bitcoin ABC Buildbot (legacy)
Build 4207: arc lint + arc unit

Event Timeline

jasonbcox requested changes to this revision.Aug 9 2018, 20:08
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
test/functional/test_framework/cashaddr.py
3 ↗(On Diff #4543)

Since these copyrights share the same date, put all of them on the same line.

21 ↗(On Diff #4543)

This entire license can be replaced with:

# Distributed under the MIT software license, see the accompanying
# file COPYING or http://www.opensource.org/licenses/mit-license.php.

This is as per usual with other files in the repo.

This revision now requires changes to proceed.Aug 9 2018, 20:08
test/functional/test_framework/blocktools.py
106 ↗(On Diff #4543)

Change this to:
addrHash = decode(node.getnewaddress())[2]

and then the new CScript line below will be easier to understand, as just:
CScript([OP_DUP, OP_HASH160, addrHash, OP_EQUALVERIFY, OP_CHECKSIG])))

test/functional/test_framework/cashaddr.py
53 ↗(On Diff #4543)

This file has lots of double-newlines. Please remove them where they aren't necessary.

110 ↗(On Diff #4543)

Is this line supposed to be (prefix, kind, hash)?

test/functional/test_framework/cashaddr.py
53 ↗(On Diff #4543)

This is the python style guideline. Arc lint adds 2 newlines between functions.

110 ↗(On Diff #4543)

Nope

jasonbcox requested changes to this revision.Aug 9 2018, 22:11
jasonbcox added inline comments.
test/functional/test_framework/cashaddr.py
92 ↗(On Diff #4551)

If the below isnt supposed to be (prefix, kind, hash) then this should say pair :P

This revision now requires changes to proceed.Aug 9 2018, 22:11

Move note about where the cashaddr module was taken from to the correct location

This revision is now accepted and ready to land.Aug 10 2018, 20:14
This revision was automatically updated to reflect the committed changes.