Page MenuHomePhabricator
Differential D15532

[Chronik] Call `SyncWithValidationInterfaceQueue` in `/broadcast-tx(s)`
ClosedPublic
Actions

Authored by tobias_ruck on Feb 23 2024, 22:02.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC19baadd6d07b: [Chronik] Call `SyncWithValidationInterfaceQueue` in `/broadcast-tx(s)`
Summary

Some tests occasionally fail because /broadcast-tx(s) returns before Chronik caught up.

Waiting using SyncWithValidationInterfaceQueue fixes this.

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-broadcast-txs-sync-validation-queue
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27376
Build 54315: Build Diffchronik-client-integration-tests · build-chronik · build-chronik-plugins
Build 54314: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Feb 23 2024, 22:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 23 2024, 22:02
tobias_ruck requested review of this revision.Feb 23 2024, 22:02
Harbormaster completed remote builds in B27372: Diff 45547.Feb 23 2024, 22:08
teamcity added a comment.Feb 23 2024, 22:08
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Feb 23 2024, 22:25
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Feb 23 2024, 22:25
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
tobias_ruck updated this revision to Diff 45551.Feb 23 2024, 22:56

fix deadlock

Harbormaster completed remote builds in B27376: Diff 45551.Feb 23 2024, 23:16
Fabien accepted this revision.Feb 24 2024, 10:12
This revision is now accepted and ready to land.Feb 24 2024, 10:12
Closed by commit rABC19baadd6d07b: [Chronik] Call `SyncWithValidationInterfaceQueue` in `/broadcast-tx(s)` (authored by tobias_ruck). · Explain WhyFeb 24 2024, 12:04
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABC19baadd6d07b: [Chronik] Call `SyncWithValidationInterfaceQueue` in `/broadcast-tx(s)`.

Revision Contents
Changeset List

PathSize
chronik/
chronik-bridge/
src/
4 lines
chronik-cpp/
2 lines
5 lines
chronik-http/
1 line
src/
21 lines

Diff 45551

View Options

Cargo.lock

Loading...
View Options

chronik/chronik-bridge/src/ffi.rs

Loading...
View Options

chronik/chronik-cpp/chronik_bridge.h

Loading...
View Options

chronik/chronik-cpp/chronik_bridge.cpp

Loading...
View Options

chronik/chronik-http/Cargo.toml

Loading...
View Options

chronik/chronik-http/src/server.rs

Loading...