Page MenuHomePhabricator

[Cashtab] Fix bugs in parseChronikTx
ClosedPublic

Authored by bytesofman on Mar 2 2024, 04:35.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCbbfbef216a5e: [Cashtab] Fix bugs in parseChronikTx
Summary

T3434

Instead of converting all strings (and buffers) to string at the end, just convert the buffers to string. Some buffers may require non-utf8 conversion later. Also, now that we are handling unrecognized lokad ids by separating the pushes with a space, we need to convert these strings individually.

Ignore op return "msgs" in etoken txs.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix-electrum-msg-parsing
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27596
Build 54755: Build Diffcashtab-tests
Build 54754: arc lint + arc unit

Event Timeline

bytesofman published this revision for review.Mar 2 2024, 04:36
bytesofman edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Mar 2 2024, 08:48
This revision was automatically updated to reflect the committed changes.