Page MenuHomePhabricator

[token-server] Add Dockerfile for CI deployments
ClosedPublic

Authored by bytesofman on Mar 8 2024, 14:52.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC7d99a4ee502f: [token-server] Add Dockerfile for CI deployments
Summary

Add Dockerfile for CI deployments. Modify tsconfig to exclude the test/ dir in builds (not needed and was throwing errors as the docker instance cannot find the local ref of mock-chronik-client)

Test Plan
docker build -t token-server_local .
docker run --init --rm --name token-server token-server_local

and app starts

Diff Detail

Repository
rABC Bitcoin ABC
Branch
token-server-deploy
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27749
Build 55060: Build Difftoken-server-tests
Build 55059: arc lint + arc unit

Event Timeline

bytesofman published this revision for review.Mar 8 2024, 14:52
Fabien requested changes to this revision.Mar 8 2024, 16:19
Fabien added a subscriber: Fabien.
Fabien added inline comments.
apps/token-server/Dockerfile
1

?

3–4

There is no stage 2 and the alias is never used

This revision now requires changes to proceed.Mar 8 2024, 16:19
bytesofman marked 2 inline comments as done.

remove copypasta

Fabien requested changes to this revision.Mar 8 2024, 20:29
Fabien added inline comments.
apps/token-server/Dockerfile
3 ↗(On Diff #46047)
This revision now requires changes to proceed.Mar 8 2024, 20:29
bytesofman marked an inline comment as done.

remove 'as builder'

This revision is now accepted and ready to land.Mar 9 2024, 08:09