Cashtab has gone through many iterations of button design without cleaning up past iterations. Standardize primary and secondary buttons.
Details
Details
- Reviewers
PiRK - Group Reviewers
Restricted Project - Commits
- rABCa5e3440acb24: [Cashtab] Simplify and standardize buttons
npm test, any aesthetic improvements / suggestions
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- cashtab-buttons
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 27817 Build 55191: Build Diff cashtab-tests Build 55190: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Failed tests logs:
====== CashTab Unit Tests: <Configure /> We can rename the active wallet or a saved wallet, we can add a wallet, we can import a wallet, we can delete a wallet ====== TestingLibraryElementError: Unable to find an accessible element with the role "button" and name "plus-square New Wallet" Here are the accessible roles: img: Name "cashtab": <img alt="cashtab" class="sc-fZwumE bcurWd" src="test-file-stub" /> Name "copy": <span aria-label="copy" class="anticon anticon-copy sc-bwzfXH gJwWNq" role="img" /> Name "exclamation-circle": <span aria-label="exclamation-circle" class="anticon anticon-exclamation-circle ant-alert-icon" role="img" /> Name "right": <span aria-label="right" class="anticon anticon-right ant-collapse-arrow" role="img" /> Name "wallet": <span aria-label="wallet" class="anticon anticon-wallet sc-bxivhb iBBRHU" role="img" /> Name "lock": <span aria-label="lock" class="anticon anticon-lock" role="img" /> Name "right": <span aria-label="right" class="anticon anticon-right ant-collapse-arrow" role="img" /> Name "contacts": <span aria-label="contacts" class="anticon anticon-contacts sc-gzVnrw eROEQT" role="img" tabindex="-1" /> Name "contacts": <span aria-label="contacts" class="anticon anticon-contacts sc-gzVnrw eROEQT" data-testid="add-saved-wallet-to-contact-btn" role="img" tabindex="-1" /> Name "contacts": <span aria-label="contacts" class="anticon anticon-contacts sc-gzVnrw eROEQT" data-testid="add-saved-wallet-to-contact-btn" role="img" tabindex="-1" /> Name "contacts": <span aria-label="contacts" class="anticon anticon-contacts sc-gzVnrw eROEQT" data-testid="add-saved-wallet-to-contact-btn" role="img" tabindex="-1" /> Name "contacts": <span aria-label="contacts" class="anticon anticon-contacts sc-gzVnrw eROEQT" data-testid="add-saved-wallet-to-contact-btn" role="img" tabindex="-1" /> Name "contacts": <span aria-label="contacts" class="anticon anticon-contacts sc-gzVnrw eROEQT" data-testid="add-saved-wallet-to-contact-btn" role="img" tabindex="-1" /> Name "contacts": <span aria-label="contacts" class="anticon anticon-contacts sc-gzVnrw eROEQT" data-testid="add-saved-wallet-to-contact-btn" role="img" tabindex="-1" /> Name "right": <span aria-label="right" class="anticon anticon-right ant-collapse-arrow" role="img" /> Name "dollar": <span aria-label="dollar" class="anticon anticon-dollar sc-htpNat lgbLiL" role="img" /> Name "setting": <span aria-label="setting" class="anticon anticon-setting sc-EHOje fuKjcV" role="img" /> Name "lock": <span aria-label="lock" class="anticon anticon-lock" role="img" /> Name "check": <span aria-label="check" class="anticon anticon-check" role="img" /> Name "close": <span aria-label="close" class="anticon anticon-close" role="img" /> Name "lock": <span aria-label="lock" class="anticon anticon-lock" role="img" /> Name "check": <span aria-label="check" class="anticon anticon-check" role="img" /> Name "close": <span aria-label="close" class="anticon anticon-close" role="img" /> Name "github": <span aria-label="github" class="anticon anticon-github sc-jKJlTe gilblv" role="img" /> Name "appstore-add": <span aria-label="appstore-add" class="anticon anticon-appstore-add" role="img" style="font-size: 24px;" /> Name "swap": <span aria-label="swap" class="anticon anticon-swap" role="img" style="font-size: 24px;" /> -------------------------------------------------- switch: Name "": <button aria-checked="true" class="ant-switch ant-switch-small css-dev-only-do-not-override-1rqnfsa ant-switch-checked" role="switch" type="button" /> Name "check close": <button aria-checked="false" class="ant-switch ant-switch-small css-dev-only-do-not-override-1rqnfsa" data-testid="send-confirmations-switch" role="switch" type="button" /> Name "check close": <button aria-checked="false" class="ant-switch ant-switch-small css-dev-only-do-not-override-1rqnfsa" role="switch" type="button" /> -------------------------------------------------- heading: Name "copy Backup your wallet": <h2 /> Name "wallet Manage Wallets": <h2 /> Name "bravo": <h3 class="notranslate" /> Name "Currently active": <h4 /> Name "ACTIVE WALLET": <h3 class="overflow notranslate" /> Name "charlie": <h3 class="overflow notranslate" /> Name "delta": <h3 class="overflow notranslate" /> Name "echo": <h3 class="overflow notranslate" /> Name "qrj4p": <h3 class="overflow notranslate" /> Name "qzxep": <h3 class="overflow notranslate" /> Name "dollar Fiat Currency": <h2 /> Name "setting General Settings": <h2 /> -------------------------------------------------- alert: Name "": <div class="ant-alert ant-alert-warning ant-alert-with-description css-dev-only-do-not-override-1rqnfsa" data-show="true" role="alert" style="margin-bottom: 12px;" /> Name "": <div class="ant-form-item-explain ant-form-item-explain-connected css-dev-only-do-not-override-1rqnfsa" role="alert" /> -------------------------------------------------- button: Name "right Click to reveal seed phrase": <div aria-disabled="false" aria-expanded="false" class="ant-collapse-header" role="button" tabindex="0" /> Name "New Wallet": <button class="sc-jAaTju sc-jDwBTQ glFrxf" /> Name "Import Wallet": <button class="sc-jAaTju sc-gPEVay djLlRS" /> Name "Import": <button class="sc-jAaTju sc-gPEVay djLlRS" /> Name "right Saved wallets": <div aria-disabled="false" aria-expanded="true" class="ant-collapse-header" role="button" tabindex="0" /> Name "Activate": <button /> Name "Activate": <button /> Name "Activate": <button /> Name "Activate": <button /> Name "Activate": <button /> Name "Activate": <button /> Name "right Contact List": <div aria-disabled="false" aria-expanded="false" class="ant-collapse-header" role="button" tabindex="0" /> Name "": <button class="sc-gmeYpB eQwTbZ" /> Name "": <button class="sc-gmeYpB eQwTbZ" data-testid="nav-btn-send" /> Name "appstore-add": <button class="sc-gmeYpB eQwTbZ" data-testid="nav-btn-etokens" /> Name "": <button class="sc-gmeYpB eQwTbZ" data-testid="nav-btn-receive" /> Name "Airdrop": <button class="sc-fcdeBU RXlWo" data-testid="nav-btn-airdrop" /> Name "Swap swap": <button class="sc-fcdeBU RXlWo" data-testid="nav-btn-swap" /> Name "Sign & Verify": <button class="sc-fcdeBU RXlWo" data-testid="nav-btn-signverifymsg" /> Name "Settings": <button class="sc-fcdeBU hJndtC" data-testid="nav-btn-configure" /> -------------------------------------------------- textbox: Name "": <input autocomplete="off" class="ant-input css-dev-only-do-not-override-1rqnfsa" name="mnemonic" placeholder="mnemonic (seed phrase)" required="" title="" type="email" value="pioneer waste next tired armed course expand stairs load brick asthma budget" /> -------------------------------------------------- combobox: Name "": <input aria-autocomplete="list" aria-controls="rc_select_TEST_OR_SSR_list" aria-expanded="false" aria-haspopup="listbox" aria-owns="rc_select_TEST_OR_SSR_list" autocomplete="off" class="ant-select-selection-search-input" id="rc_select_TEST_OR_SSR" readonly="" role="combobox" style="opacity: 0;" type="search" unselectable="on" value="" /> -------------------------------------------------- link: Name "": <a class="sc-kpOJdX kTvxAf" href="https://x.com/cashtabwallet" rel="noreferrer" target="_blank" /> Name "": <a class="sc-kpOJdX kTvxAf" href="https://www.facebook.com/Cashtab" rel="noreferrer" target="_blank" /> Name "github": <a class="sc-kpOJdX kTvxAf" href="https://github.com/Bitcoin-ABC/bitcoin-abc/tree/master/cashtab" rel="noreferrer" target="_blank" /> -------------------------------------------------- Ignored nodes: comments, script, style <body> <div class="ant-notification ant-notification-topRight css-dev-only-do-not-override-1rqnfsa ant-notification-stack ant-notification-stack-expanded" style="right: 0px; top: 24px;" /> <div> <div class="ant-spin-nested-loading css-dev-only-do-not-override-1rqnfsa" > <div class="ant-spin-container" > <div class="sc-LKuAh jSXNAo" > <div class="sc-kZmsYB eHkWzo" > <div class="sc-RcBXQ gMCskf" > <div class="sc-hzNEM iiFjIO" > <div class="sc-iSDuPN ccpgHi" > <img alt="cashtab" class="sc-fZwumE bcurWd" src="test-file-stub" /> <div class="sc-etwtAo fHyTnr" > Settings <svg height="33px" width="30px" /> </div> </div> <div class="sc-bYSBpT dbDmUC" data-testid="wallet-info-ctn" > <div class="sc-dEoRIm iVOOxs" > <div class="sc-jtggT dNidya" > bravo </div> <div> <button aria-checked="true" class="ant-switch ant-switch-small css-dev-only-do-not-override-1rqnfsa ant-switch-checked" role="switch" type="button" > <div class="ant-switch-handle" /> <span class="ant-switch-inner" > <span class="ant-switch-inner-checked" > <svg class="sc-cSHVUG bgwEHu" /> </span> <span class="ant-switch-inner-unchecked" > <svg class="sc-kAzzGY fUTkYj" /> </span> </span> </button> </div> </div> <div class="sc-ebFjAB kxaSkj" data-testid="balance-xec" > 0.00 XEC </div> <div class="sc-jKVCRD bKzIGa" data-testid="balance-fiat" > $ 0.00 USD </div> <p class="sc-kaNhvL kDOvrh" data-testid="ecash-price" > 1 XEC = 0.00003000 USD </p> </div> </div> <div class="sc-btzYZH hekFVg" data-testid="configure-ctn" > <div class="sc-fzsDOv edkcDs" > <h2> <span aria-label="copy" class="anticon anticon-copy sc-bwzfXH gJwWNq" role="img" > <svg aria-hidden="true" data-icon="copy" fill="currentColor" focusable="false" height="1em" viewBox="64 64 896 896" width="1em" > <path d="M832 64H296c-4.4 0-8 3.6-8 8v56c0 4.4 3.6 8 8 8h496v688c0 4.4 3.6 8 8 8h56c4.4 0 8-3.6 8-8V96c0-17.7-14.3-32-32-32zM704 192H192c-17.7 0-32 14.3-32 32v530.7c0 8.5 3.4 16.6 9.4 22.6l173.3 173.3c2.2 2.2 4.7 4 7.4 5.5v1.9h4.2c3.5 1.3 7.2 2 11 2H704c17.7 0 32-14.3 32-32V224c0-17.7-14.3-32-32-32zM350 856.2L263.9 770H350v86.2zM664 888H414V746c0-22.1-17.9-40-40-40H232V264h432v624z" /> </svg> </span> Backup your wallet </h2> <div class="ant-alert ant-alert-warning ant-alert-with-description css-dev-only-do-not-override-... at Object.getElementError (/work/cashtab/node_modules/@testing-library/dom/dist/config.js:37:19) at /work/cashtab/node_modules/@testing-library/dom/dist/query-helpers.js:76:38 at /work/cashtab/node_modules/@testing-library/dom/dist/query-helpers.js:52:17 at /work/cashtab/node_modules/@testing-library/dom/dist/query-helpers.js:95:19 at Object.getByRole (/work/cashtab/src/components/Configure/__tests__/Configure.test.js:632:20)
Each failure log is accessible here:
CashTab Unit Tests: <Configure /> We can rename the active wallet or a saved wallet, we can add a wallet, we can import a wallet, we can delete a wallet
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Failed tests logs:
====== CashTab Unit Tests: <Configure /> We can rename the active wallet or a saved wallet, we can add a wallet, we can import a wallet, we can delete a wallet ====== TestingLibraryElementError: Unable to find an accessible element with the role "button" and name "plus-square New Wallet" Here are the accessible roles: img: Name "loading": <span aria-label="loading" class="anticon anticon-loading anticon-spin cashLoadingIcon ant-spin-dot" role="img" /> Name "cashtab": <img alt="cashtab" class="sc-fZwumE bcurWd" src="test-file-stub" /> Name "copy": <span aria-label="copy" class="anticon anticon-copy sc-bwzfXH gJwWNq" role="img" /> Name "exclamation-circle": <span aria-label="exclamation-circle" class="anticon anticon-exclamation-circle ant-alert-icon" role="img" /> Name "right": <span aria-label="right" class="anticon anticon-right ant-collapse-arrow" role="img" /> Name "wallet": <span aria-label="wallet" class="anticon anticon-wallet sc-bxivhb iBBRHU" role="img" /> Name "lock": <span aria-label="lock" class="anticon anticon-lock" role="img" /> Name "right": <span aria-label="right" class="anticon anticon-right ant-collapse-arrow" role="img" /> Name "contacts": <span aria-label="contacts" class="anticon anticon-contacts sc-gzVnrw eROEQT" role="img" tabindex="-1" /> Name "contacts": <span aria-label="contacts" class="anticon anticon-contacts sc-gzVnrw eROEQT" data-testid="add-saved-wallet-to-contact-btn" role="img" tabindex="-1" /> Name "contacts": <span aria-label="contacts" class="anticon anticon-contacts sc-gzVnrw eROEQT" data-testid="add-saved-wallet-to-contact-btn" role="img" tabindex="-1" /> Name "contacts": <span aria-label="contacts" class="anticon anticon-contacts sc-gzVnrw eROEQT" data-testid="add-saved-wallet-to-contact-btn" role="img" tabindex="-1" /> Name "contacts": <span aria-label="contacts" class="anticon anticon-contacts sc-gzVnrw eROEQT" data-testid="add-saved-wallet-to-contact-btn" role="img" tabindex="-1" /> Name "contacts": <span aria-label="contacts" class="anticon anticon-contacts sc-gzVnrw eROEQT" data-testid="add-saved-wallet-to-contact-btn" role="img" tabindex="-1" /> Name "contacts": <span aria-label="contacts" class="anticon anticon-contacts sc-gzVnrw eROEQT" data-testid="add-saved-wallet-to-contact-btn" role="img" tabindex="-1" /> Name "right": <span aria-label="right" class="anticon anticon-right ant-collapse-arrow" role="img" /> Name "dollar": <span aria-label="dollar" class="anticon anticon-dollar sc-htpNat lgbLiL" role="img" /> Name "setting": <span aria-label="setting" class="anticon anticon-setting sc-EHOje fuKjcV" role="img" /> Name "lock": <span aria-label="lock" class="anticon anticon-lock" role="img" /> Name "check": <span aria-label="check" class="anticon anticon-check" role="img" /> Name "close": <span aria-label="close" class="anticon anticon-close" role="img" /> Name "lock": <span aria-label="lock" class="anticon anticon-lock" role="img" /> Name "check": <span aria-label="check" class="anticon anticon-check" role="img" /> Name "close": <span aria-label="close" class="anticon anticon-close" role="img" /> Name "github": <span aria-label="github" class="anticon anticon-github sc-jKJlTe gilblv" role="img" /> Name "appstore-add": <span aria-label="appstore-add" class="anticon anticon-appstore-add" role="img" style="font-size: 24px;" /> Name "swap": <span aria-label="swap" class="anticon anticon-swap" role="img" style="font-size: 24px;" /> -------------------------------------------------- switch: Name "": <button aria-checked="true" class="ant-switch ant-switch-small css-dev-only-do-not-override-1rqnfsa ant-switch-checked" role="switch" type="button" /> Name "check close": <button aria-checked="false" class="ant-switch ant-switch-small css-dev-only-do-not-override-1rqnfsa" data-testid="send-confirmations-switch" role="switch" type="button" /> Name "check close": <button aria-checked="false" class="ant-switch ant-switch-small css-dev-only-do-not-override-1rqnfsa" role="switch" type="button" /> -------------------------------------------------- heading: Name "copy Backup your wallet": <h2 /> Name "wallet Manage Wallets": <h2 /> Name "bravo": <h3 class="notranslate" /> Name "Currently active": <h4 /> Name "ACTIVE WALLET": <h3 class="overflow notranslate" /> Name "charlie": <h3 class="overflow notranslate" /> Name "delta": <h3 class="overflow notranslate" /> Name "echo": <h3 class="overflow notranslate" /> Name "qrj4p": <h3 class="overflow notranslate" /> Name "qzxep": <h3 class="overflow notranslate" /> Name "dollar Fiat Currency": <h2 /> Name "setting General Settings": <h2 /> -------------------------------------------------- alert: Name "": <div class="ant-alert ant-alert-warning ant-alert-with-description css-dev-only-do-not-override-1rqnfsa" data-show="true" role="alert" style="margin-bottom: 12px;" /> Name "": <div class="ant-form-item-explain ant-form-item-explain-connected css-dev-only-do-not-override-1rqnfsa" role="alert" /> -------------------------------------------------- button: Name "right Click to reveal seed phrase": <div aria-disabled="false" aria-expanded="false" class="ant-collapse-header" role="button" tabindex="0" /> Name "New Wallet": <button class="sc-jAaTju sc-jDwBTQ glFrxf" /> Name "Import Wallet": <button class="sc-jAaTju sc-gPEVay djLlRS" /> Name "Import": <button class="sc-jAaTju sc-gPEVay djLlRS" /> Name "right Saved wallets": <div aria-disabled="false" aria-expanded="true" class="ant-collapse-header" role="button" tabindex="0" /> Name "Activate": <button /> Name "Activate": <button /> Name "Activate": <button /> Name "Activate": <button /> Name "Activate": <button /> Name "Activate": <button /> Name "right Contact List": <div aria-disabled="false" aria-expanded="false" class="ant-collapse-header" role="button" tabindex="0" /> Name "": <button class="sc-gmeYpB eQwTbZ" /> Name "": <button class="sc-gmeYpB eQwTbZ" data-testid="nav-btn-send" /> Name "appstore-add": <button class="sc-gmeYpB eQwTbZ" data-testid="nav-btn-etokens" /> Name "": <button class="sc-gmeYpB eQwTbZ" data-testid="nav-btn-receive" /> Name "Airdrop": <button class="sc-fcdeBU RXlWo" data-testid="nav-btn-airdrop" /> Name "Swap swap": <button class="sc-fcdeBU RXlWo" data-testid="nav-btn-swap" /> Name "Sign & Verify": <button class="sc-fcdeBU RXlWo" data-testid="nav-btn-signverifymsg" /> Name "Settings": <button class="sc-fcdeBU hJndtC" data-testid="nav-btn-configure" /> -------------------------------------------------- textbox: Name "": <input autocomplete="off" class="ant-input css-dev-only-do-not-override-1rqnfsa" name="mnemonic" placeholder="mnemonic (seed phrase)" required="" title="" type="email" value="pioneer waste next tired armed course expand stairs load brick asthma budget" /> -------------------------------------------------- combobox: Name "": <input aria-autocomplete="list" aria-controls="rc_select_TEST_OR_SSR_list" aria-expanded="false" aria-haspopup="listbox" aria-owns="rc_select_TEST_OR_SSR_list" autocomplete="off" class="ant-select-selection-search-input" id="rc_select_TEST_OR_SSR" readonly="" role="combobox" style="opacity: 0;" type="search" unselectable="on" value="" /> -------------------------------------------------- link: Name "": <a class="sc-kpOJdX kTvxAf" href="https://x.com/cashtabwallet" rel="noreferrer" target="_blank" /> Name "": <a class="sc-kpOJdX kTvxAf" href="https://www.facebook.com/Cashtab" rel="noreferrer" target="_blank" /> Name "github": <a class="sc-kpOJdX kTvxAf" href="https://github.com/Bitcoin-ABC/bitcoin-abc/tree/master/cashtab" rel="noreferrer" target="_blank" /> -------------------------------------------------- Ignored nodes: comments, script, style <body> <div class="ant-notification ant-notification-topRight css-dev-only-do-not-override-1rqnfsa ant-notification-stack ant-notification-stack-expanded" style="right: 0px; top: 24px;" /> <div> <div class="ant-spin-nested-loading css-dev-only-do-not-override-1rqnfsa" > <div> <div aria-busy="true" aria-live="polite" class="ant-spin ant-spin-spinning css-dev-only-do-not-override-1rqnfsa" > <span aria-label="loading" class="anticon anticon-loading anticon-spin cashLoadingIcon ant-spin-dot" role="img" > <svg aria-hidden="true" data-icon="loading" fill="currentColor" focusable="false" height="1em" viewBox="0 0 1024 1024" width="1em" > <path d="M988 548c-19.9 0-36-16.1-36-36 0-59.4-11.6-117-34.6-171.3a440.45 440.45 0 00-94.3-139.9 437.71 437.71 0 00-139.9-94.3C629 83.6 571.4 72 512 72c-19.9 0-36-16.1-36-36s16.1-36 36-36c69.1 0 136.2 13.5 199.3 40.3C772.3 66 827 103 874 150c47 47 83.9 101.8 109.7 162.7 26.7 63.1 40.2 130.2 40.2 199.3.1 19.9-16 36-35.9 36z" /> </svg> </span> </div> </div> <div class="ant-spin-container ant-spin-blur" > <div class="sc-LKuAh jSXNAo" > <div class="sc-kZmsYB eHkWzo" > <div class="sc-RcBXQ gMCskf" > <div class="sc-hzNEM iiFjIO" > <div class="sc-iSDuPN ccpgHi" > <img alt="cashtab" class="sc-fZwumE bcurWd" src="test-file-stub" /> <div class="sc-etwtAo fHyTnr" > Settings <svg height="33px" width="30px" /> </div> </div> <div class="sc-bYSBpT dbDmUC" data-testid="wallet-info-ctn" > <div class="sc-dEoRIm iVOOxs" > <div class="sc-jtggT dNidya" > bravo </div> <div> <button aria-checked="true" class="ant-switch ant-switch-small css-dev-only-do-not-override-1rqnfsa ant-switch-checked" role="switch" type="button" > <div class="ant-switch-handle" /> <span class="ant-switch-inner" > <span class="ant-switch-inner-checked" > <svg class="sc-cSHVUG bgwEHu" /> </span> <span class="ant-switch-inner-unchecked" > <svg class="sc-kAzzGY fUTkYj" /> </span> </span> </button> </div> </div> <div class="sc-ebFjAB kxaSkj" data-testid="balance-xec" > 0.00 XEC </div> <div class="sc-jKVCRD bKzIGa" data-testid="balance-fiat" > $ 0.00 USD </div> <p class="sc-kaNhvL kDOvrh" data-testid="ecash-price" > 1 XEC = 0.00003000 USD </p> </div> </div> <div class="sc-btzYZH hekFVg" data-testid="configure-ctn" > <div class="sc-fzsDOv edkcDs" > <h2> <span aria-label="copy" class... at Object.getElementError (/work/cashtab/node_modules/@testing-library/dom/dist/config.js:37:19) at /work/cashtab/node_modules/@testing-library/dom/dist/query-helpers.js:76:38 at /work/cashtab/node_modules/@testing-library/dom/dist/query-helpers.js:52:17 at /work/cashtab/node_modules/@testing-library/dom/dist/query-helpers.js:95:19 at Object.getByRole (/work/cashtab/src/components/Configure/__tests__/Configure.test.js:632:20) at runNextTicks (node:internal/process/task_queues:60:5) at listOnTimeout (node:internal/timers:540:9) at processTimers (node:internal/timers:514:7)
Each failure log is accessible here:
CashTab Unit Tests: <Configure /> We can rename the active wallet or a saved wallet, we can add a wallet, we can import a wallet, we can delete a wallet