Differential D15741

[guix] Fix guix-clean on CI
ClosedPublic
Actions

Authored by Fabien on Mar 20 2024, 12:52.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCf1dbd8bd6951: [guix] Fix guix-clean on CI

Summary

It is not possible to pass a bash array as an environment variable, so the extra excludes are not properly expanded and cause git clean to fail silently.

Test Plan

Create some in tree directory, then:

./contrib/teamcity/build-configurations.py guix-osx

Check the directlry is removed.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

guix_ci_fix

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 27949
Build 55448: Build Diff
Build 55447: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 20 2024, 12:52

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 20 2024, 12:52

Fabien requested review of this revision.Mar 20 2024, 12:52

Harbormaster completed remote builds in B27949: Diff 46320.Mar 20 2024, 12:52

PiRK accepted this revision.Mar 20 2024, 14:22

This revision is now accepted and ready to land.Mar 20 2024, 14:22

Closed by commit rABCf1dbd8bd6951: [guix] Fix guix-clean on CI (authored by Fabien). · Explain WhyMar 20 2024, 14:23

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCf1dbd8bd6951: [guix] Fix guix-clean on CI.

Revision Contents
Changeset List

Path

Size

contrib/

guix/

guix-clean

3 lines

teamcity/

guix.sh

2 lines

Diff 46320

View Options

contrib/guix/guix-clean