Differential D1677

Parse the TxId as a TxId in bitcoin-tx.cpp
ClosedPublic
Actions

Authored by deadalnix on Aug 25 2018, 13:43.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING35e370341c11: Parse the TxId as a TxId in bitcoin-tx.cpp
rABC35e370341c11: Parse the TxId as a TxId in bitcoin-tx.cpp

Summary

This improves type safety.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

bitcointxtxid

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3125
Build 4337: Bitcoin ABC Buildbot (legacy)
Build 4336: arc lint + arc unit

Event Timeline

deadalnix created this revision.Aug 25 2018, 13:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 25 2018, 13:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3125: Diff 4651.Aug 25 2018, 14:19

schancel accepted this revision.Aug 25 2018, 16:40

This revision is now accepted and ready to land.Aug 25 2018, 16:40

Closed by commit rABC35e370341c11: Parse the TxId as a TxId in bitcoin-tx.cpp (authored by deadalnix). · Explain WhyAug 25 2018, 16:52

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

2 lines

Diff 4651

src/bitcoin-tx.cpp

Loading...