[test] allow passing test checkpoints to ContextualCheckBlockHeader
ClosedPublic
Actions

Authored by PiRK on Mar 30 2024, 20:58.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCa51d89123b68: [test] allow passing test checkpoints to ContextualCheckBlockHeader

Summary

This enables testing the checkpoints without having to hack a Config and a CChainParams.
It is an alternative approach to D15802 and unbreaks the address sanitizer build that was broken by that diff.

Test Plan

ninja all check-all

address sanitizer build

Diff Detail

Repository

rABC Bitcoin ABC

Branch

refs/heads/fix_initialization-order-fiasco2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28200
Build 55945: Build Diff	lint-circular-dependencies · build-without-wallet · build-clang-tidy · build-debug · build-diff · build-clang
Build 55944: arc lint + arc unit

Event Timeline

PiRK created this revision.Mar 30 2024, 20:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 30 2024, 20:58

while we are touching these lines, don't assert that the chainman is not a nullptr more than once. It was done inconsistently in this test, doing it once for the first call is enough.

@bot build-asan

teamcity awarded a token.Mar 30 2024, 21:04

Harbormaster completed remote builds in B28199: Diff 46649.Mar 30 2024, 21:17

Harbormaster completed remote builds in B28200: Diff 46650.Mar 30 2024, 21:22

PiRK published this revision for review.Mar 30 2024, 21:27

PiRK edited the summary of this revision. (Show Details)Mar 30 2024, 22:47

Fabien accepted this revision.Mar 31 2024, 09:25

This revision is now accepted and ready to land.Mar 31 2024, 09:25

Closed by commit rABCa51d89123b68: [test] allow passing test checkpoints to ContextualCheckBlockHeader (authored by PiRK). · Explain WhyMar 31 2024, 10:13

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCa51d89123b68: [test] allow passing test checkpoints to ContextualCheckBlockHeader.