Page MenuHomePhabricator

[avalanche] Fix a race in abc_p2p_avalanche_remote_proofs.py
ClosedPublic

Authored by Fabien on Apr 1 2024, 16:24.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC1efdb388195f: [avalanche] Fix a race in abc_p2p_avalanche_remote_proofs.py
Summary

The compact proofs are sent periodically so it's possible for the trigger_avaproofs() function to return on a previously sent message and cause the test to fail. This diff addresses this by using a retry loop and checking the last_update time to make sure we're looking at the correct message.

Test Plan
./test/functional/test_runner.py abc_p2p_avalanche_remote_proofs

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_fix_remote_proofs_flakiness
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28233
Build 56011: Build Diffbuild-without-wallet · build-debug · build-diff · build-clang · build-clang-tidy
Build 56010: arc lint + arc unit