Page MenuHomePhabricator
Differential D1682

Use Txid in CWallet::GetWalletTx
ClosedPublic
Actions

Authored by deadalnix on Aug 25 2018, 18:12.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING693b0fcd979c: Use Txid in CWallet::GetWalletTx
rABC693b0fcd979c: Use Txid in CWallet::GetWalletTx
Summary

Also fix callsites.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
GetWalletTxId
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3137
Build 4361: Bitcoin ABC Buildbot (legacy)
Build 4360: arc lint + arc unit

Event Timeline

deadalnix created this revision.Aug 25 2018, 18:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 25 2018, 18:12
teamcity added a subscriber: teamcity.Aug 25 2018, 18:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 25 2018, 18:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3131: Diff 4665!Aug 25 2018, 18:50
schancel accepted this revision.Aug 26 2018, 01:30
This revision is now accepted and ready to land.Aug 26 2018, 01:30
deadalnix updated this revision to Diff 4672.Aug 26 2018, 13:07

rebase

teamcity added a comment.Aug 26 2018, 13:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 26 2018, 13:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3137: Diff 4672.Aug 26 2018, 13:46
Closed by commit rABC693b0fcd979c: Use Txid in CWallet::GetWalletTx (authored by deadalnix). · Explain WhyAug 26 2018, 14:35
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
qt/
10 lines
2 lines
14 lines
wallet/
test/
5 lines
2 lines
4 lines

Diff 4672

View Options

src/qt/transactionview.cpp

Loading...
View Options

src/qt/walletmodel.h

Loading...
View Options

src/qt/walletmodel.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...