Page MenuHomePhabricator
Differential D1683

Use TxId in wallet's GetConflicts methods
ClosedPublic
Actions

Authored by deadalnix on Aug 25 2018, 18:38.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING1ef5b9c118f9: Use TxId in wallet's GetConflicts methods
rABC1ef5b9c118f9: Use TxId in wallet's GetConflicts methods
Summary

As per title.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
GetConflictsTxId
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3139
Build 4365: Bitcoin ABC Buildbot (legacy)
Build 4364: arc lint + arc unit

Event Timeline

deadalnix created this revision.Aug 25 2018, 18:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 25 2018, 18:38
teamcity added a subscriber: teamcity.Aug 25 2018, 18:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B3132: Diff 4666!Aug 25 2018, 18:48
teamcity added a comment.Aug 25 2018, 18:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

deadalnix added a child revision: D1685: Use TxId in AbandonTransaction.Aug 25 2018, 20:02
schancel accepted this revision.Aug 26 2018, 01:30
This revision is now accepted and ready to land.Aug 26 2018, 01:30
deadalnix updated this revision to Diff 4674.Aug 26 2018, 13:13

rebase

teamcity added a comment.Aug 26 2018, 13:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 26 2018, 13:25

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3139: Diff 4674!Aug 26 2018, 13:26
deadalnix added a child revision: D1688: Use TxId in CWallet::MarkConflicted.Aug 26 2018, 13:28
deadalnix updated this revision to Diff 4680.Aug 26 2018, 14:42

rebase

teamcity added a comment.Aug 26 2018, 14:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3143: Diff 4680.Aug 26 2018, 15:20
teamcity added a comment.Aug 26 2018, 15:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABC1ef5b9c118f9: Use TxId in wallet's GetConflicts methods (authored by deadalnix). · Explain WhyAug 26 2018, 15:37
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
wallet/
6 lines
14 lines

Diff 4674

View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...