Differential D15878

[chronik] Don't show "Stopping Chronik..." in the log when chronik is not enabled
ClosedPublic
Actions

Authored by Fabien on Apr 3 2024, 19:43.

Details

Reviewers

tobias_ruck

Group Reviewers

Restricted Project

Commits

rABC2bd87da937a2: [chronik] Don't show "Stopping Chronik..." in the log when chronik is not…

Summary

The chronik::Stop() function is called unconditionally if chronik is built-in, even if it is not enabled via the node option which is confusing.

Test Plan

Build with Chronik, then:

./src/bitcoind

After a few seconds, kill bitcoind with CTRL+C and check the log doesn't contain any chronik related line.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 3 2024, 19:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 3 2024, 19:43

Fabien requested review of this revision.Apr 3 2024, 19:43

tobias_ruck accepted this revision.Apr 3 2024, 19:48

This revision is now accepted and ready to land.Apr 3 2024, 19:48

This revision was landed with ongoing or failed builds.Apr 3 2024, 19:52

Closed by commit rABC2bd87da937a2: [chronik] Don't show "Stopping Chronik..." in the log when chronik is not… (authored by Fabien). · Explain Why

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC2bd87da937a2: [chronik] Don't show "Stopping Chronik..." in the log when chronik is not….

Harbormaster completed remote builds in B28303: Diff 46794.Apr 3 2024, 20:02

Revision Contents
Changeset List

Path

Size

src/

init.cpp

4 lines

Diff 46795

View Options

[chronik] Don't show "Stopping Chronik..." in the log when chronik is not enabledClosedPublicActions