Paths

Table of Contentst

Differential D15915

[Cashtab] Do not show parsed op return raw field if no input
ClosedPublic
Actions

Authored by bytesofman on Apr 6 2024, 19:01.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABCd7d7fc694b40: [Cashtab] Do not show parsed op return raw field if no input

Summary

This is already the expected behavior, but it is not working as there is a typo in which formData field to check for being blank.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

no-parsed-if-input-blank

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28379
Build 56300: Build Diff	cashtab-tests
Build 56299: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 6 2024, 19:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 6 2024, 19:01

confirm with a test

Harbormaster completed remote builds in B28378: Diff 46908.Apr 6 2024, 19:05

Harbormaster completed remote builds in B28379: Diff 46909.Apr 6 2024, 19:07

bytesofman published this revision for review.Apr 6 2024, 19:11

emack accepted this revision.Apr 7 2024, 09:10

This revision is now accepted and ready to land.Apr 7 2024, 09:10

Closed by commit rABCd7d7fc694b40: [Cashtab] Do not show parsed op return raw field if no input (authored by bytesofman). · Explain WhyApr 7 2024, 14:58

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCd7d7fc694b40: [Cashtab] Do not show parsed op return raw field if no input.

Revision Contents
Changeset List

Path

Size

cashtab/

src/

components/

Send/

SendXec.js

2 lines

__tests__/

SendXec.test.js

8 lines

Diff 46909

View Options

cashtab/src/components/Send/SendXec.js

View Options

cashtab/src/components/Send/tests/SendXec.test.js

[Cashtab] Do not show parsed op return raw field if no inputClosedPublicActions