Page MenuHomePhabricator
Differential D1694

Use TxId in TransactionRecord
ClosedPublic
Actions

Authored by deadalnix on Aug 26 2018, 17:21.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGefd59a7fb0d0: Use TxId in TransactionRecord
rABCefd59a7fb0d0: Use TxId in TransactionRecord
Summary

As per title.

Depends on D1693 and D1692

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
TransactionRecordTxId
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3163
Build 4413: Bitcoin ABC Buildbot (legacy)
Build 4412: arc lint + arc unit

Event Timeline

deadalnix created this revision.Aug 26 2018, 17:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 26 2018, 17:21
teamcity added a subscriber: teamcity.Aug 26 2018, 17:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added a child revision: D1695: Use TxId in CWallet::mapTx.Aug 26 2018, 17:34
Harbormaster completed remote builds in B3153: Diff 4693.Aug 26 2018, 17:58
teamcity added a comment.Aug 26 2018, 17:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox requested changes to this revision.Aug 27 2018, 05:58
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/qt/transactiontablemodel.cpp
195 ↗(On Diff #4693)

uint256 could be TxId

This revision now requires changes to proceed.Aug 27 2018, 05:58
deadalnix updated this revision to Diff 4706.Aug 27 2018, 14:15

rebase

teamcity added a comment.Aug 27 2018, 14:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 27 2018, 14:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3163: Diff 4706.Aug 27 2018, 14:52
jasonbcox accepted this revision.Sep 2 2018, 16:41
This revision is now accepted and ready to land.Sep 2 2018, 16:41
Closed by commit rABCefd59a7fb0d0: Use TxId in TransactionRecord (authored by deadalnix). · Explain WhySep 2 2018, 16:42
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4706

View Options

src/qt/transactionrecord.h

Loading...
View Options

src/qt/transactionrecord.cpp

Loading...
View Options

src/qt/transactiontablemodel.cpp

Loading...