Page MenuHomePhabricator

Update amount's modulo to be the proper type.
ClosedPublic

Authored by deadalnix on Sep 3 2018, 14:33.

Details

Summary

Computer define division and modulo such as

b * (a / b) + a % b = a

It follows that a % b is the same type as a.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
modulotype
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3171
Build 4429: Bitcoin ABC Buildbot (legacy)
Build 4428: arc lint + arc unit

Event Timeline

jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/rpc/server.cpp
157 ↗(On Diff #4737)

Yoda style not believe in, do you?

This revision is now accepted and ready to land.Sep 4 2018, 17:36
src/rpc/server.cpp
157 ↗(On Diff #4737)

no :)

This revision was automatically updated to reflect the committed changes.