Use SATOSHI rather than Amount construction
ClosedPublic
Actions

Authored by deadalnix on Sep 3 2018, 17:40.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING6ce7b406829f: Use SATOSHI rather than Amount construction
rABC6ce7b406829f: Use SATOSHI rather than Amount construction

Summary

The Amount constructor has the notion of satoshi built in. If we want higher precision amount in the future, we need to make that assumption in the code explicit.

As a first step Amount(1) is now SATOSHI and Amount(-1) is now -SATOSHI

Depends on D1704

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

zerosat

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3174
Build 4435: Bitcoin ABC Buildbot (legacy)
Build 4434: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 3 2018, 17:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 3 2018, 17:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added a child revision: D1706: Amount(0) => Amount::zero().Sep 3 2018, 18:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3174: Diff 4726.Sep 3 2018, 18:19

jasonbcox accepted this revision.Sep 4 2018, 05:48

This revision is now accepted and ready to land.Sep 4 2018, 05:48

Closed by commit rABC6ce7b406829f: Use SATOSHI rather than Amount construction (authored by deadalnix). · Explain WhySep 4 2018, 10:12

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

feerate.cpp

6 lines

miner.cpp

2 lines

policy/

fees.cpp

3 lines

primitives/

transaction.h

4 lines

qt/

overviewpage.cpp

2 lines

test/

2 lines

20 lines

2 lines

4 lines

2 lines

script_P2SH_tests.cpp

4 lines

script_tests.cpp

2 lines

sigopcount_tests.cpp

6 lines

transaction_tests.cpp

6 lines

wallet/

test/

accounting_tests.cpp

6 lines

wallet_tests.cpp

2 lines

Diff 4726

View Options

src/feerate.cpp

View Options

src/miner.cpp

View Options

src/policy/fees.cpp

View Options

src/primitives/transaction.h

View Options

src/qt/overviewpage.cpp

View Options

src/test/compress_tests.cpp

View Options

src/test/feerate_tests.cpp

View Options

src/test/miner_tests.cpp

View Options

src/test/multisig_tests.cpp

View Options

src/test/rpc_tests.cpp

View Options

src/test/script_P2SH_tests.cpp

View Options

src/test/script_tests.cpp

View Options

src/test/sigopcount_tests.cpp

View Options

src/test/transaction_tests.cpp

View Options

src/wallet/test/accounting_tests.cpp

View Options

src/wallet/test/wallet_tests.cpp

Use SATOSHI rather than Amount constructionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 4726

src/feerate.cpp

src/miner.cpp

src/policy/fees.cpp

src/primitives/transaction.h

src/qt/overviewpage.cpp

src/test/compress_tests.cpp

src/test/feerate_tests.cpp

src/test/miner_tests.cpp

src/test/multisig_tests.cpp

src/test/rpc_tests.cpp

src/test/script_P2SH_tests.cpp

src/test/script_tests.cpp

src/test/sigopcount_tests.cpp

src/test/transaction_tests.cpp

src/wallet/test/accounting_tests.cpp

src/wallet/test/wallet_tests.cpp

Use SATOSHI rather than Amount construction
ClosedPublic
Actions

Revision Contents
Changeset List