[Cashtab] Start reward countdown automatically after claiming rewards
ClosedPublic
Actions

Authored by bytesofman on Apr 18 2024, 12:57.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABCd8314b5704b6: [Cashtab] Start reward countdown automatically after claiming rewards

Summary

After claiming a reward, eligibility resets (per address). Right now, Cashtab does not automatically make an API request, so the button remains enabled (and will throw an error if the user clicks it).

Better to have the button automatically change to the countdown after a claim.

Test Plan

npm start, claim a reward with an eligibile wallet, notice the countdown appears

Diff Detail

Repository

rABC Bitcoin ABC

Branch

rewards-reset-eligibility-after-claim

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28642
Build 56825: Build Diff	cashtab-tests
Build 56824: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 18 2024, 12:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 18 2024, 12:57

bytesofman published this revision for review.Apr 18 2024, 13:01

The button changes to the timer all ok, and the reward is received all ok as well. However clicking on the received CACHET throws this:

This revision now requires changes to proceed.Apr 18 2024, 13:07

In D16014#362266, @emack wrote:

The button changes to the timer all ok, and the reward is received all ok as well. However clicking on the received CACHET throws this:

will check this out but this does not seem related to this diff

As per tg chat

This revision is now accepted and ready to land.Apr 18 2024, 13:09

Harbormaster completed remote builds in B28642: Diff 47268.Apr 18 2024, 13:28

Closed by commit rABCd8314b5704b6: [Cashtab] Start reward countdown automatically after claiming rewards (authored by bytesofman). · Explain WhyApr 18 2024, 13:29

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCd8314b5704b6: [Cashtab] Start reward countdown automatically after claiming rewards.