[token-server] Support creating tokens with icons from locally run cashtab
ClosedPublic
Actions

Authored by bytesofman on Apr 19 2024, 19:11.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC7a2d1b33b1a5: [token-server] Support creating tokens with icons from locally run cashtab

Summary

The pain-in-the-ass of forgetting this is not supported while testing is imo more impactful than the potential ddos vector of someone hitting this API from localhost:3000

Test Plan

npm test, will need to test with local cashtab after this is live but it does work locally

Diff Detail

Repository

rABC Bitcoin ABC

Branch

localhost-icons

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28678
Build 56897: Build Diff	token-server-tests
Build 56896: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 19 2024, 19:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 19 2024, 19:11

bytesofman published this revision for review.Apr 19 2024, 19:11

Harbormaster completed remote builds in B28678: Diff 47328.Apr 19 2024, 19:13

This revision is now accepted and ready to land.Apr 20 2024, 07:57

Closed by commit rABC7a2d1b33b1a5: [token-server] Support creating tokens with icons from locally run cashtab (authored by bytesofman). · Explain WhyApr 20 2024, 11:56

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC7a2d1b33b1a5: [token-server] Support creating tokens with icons from locally run cashtab.

Revision Contents
Changeset List

Path

Size

apps/

token-server/

config.ts

1 line

Diff 47328

View Options

apps/token-server/config.ts

[token-server] Support creating tokens with icons from locally run cashtabClosedPublicActions