Page MenuHomePhabricator
Differential D1709

Amount(0LL) => Amount::zero() and Amount(1LL) => SATOSHI
ClosedPublic
Actions

Authored by deadalnix on Sep 4 2018, 14:43.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGc6af1b0228db: Amount(0LL) => Amount::zero() and Amount(1LL) => SATOSHI
rABCc6af1b0228db: Amount(0LL) => Amount::zero() and Amount(1LL) => SATOSHI
Summary

As per title.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
maountzero
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3179
Build 4445: Bitcoin ABC Buildbot (legacy)
Build 4444: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 4 2018, 14:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 4 2018, 14:43
teamcity added a subscriber: teamcity.Sep 4 2018, 14:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 4 2018, 15:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3179: Diff 4739.Sep 4 2018, 15:22
jasonbcox accepted this revision.Sep 4 2018, 17:33
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/test/rpc_tests.cpp
245

The below line is shorter and nicer to read as just SATOSHI. Do you think it makes sense to add ZERO_SATOSHI or ZERO_AMOUNT as a constant?

This revision is now accepted and ready to land.Sep 4 2018, 17:33
deadalnix added inline comments.Sep 4 2018, 17:42
src/test/rpc_tests.cpp
245

Maybe. It's easy to add a constant for this.

Closed by commit rABCc6af1b0228db: Amount(0LL) => Amount::zero() and Amount(1LL) => SATOSHI (authored by deadalnix). · Explain WhySep 4 2018, 17:45
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
test/
14 lines
13 lines

Diff 4739

View Options

src/test/mempool_tests.cpp

Loading...
View Options

src/test/rpc_tests.cpp

Loading...