Paths

Table of Contentst

Differential D16056

[Cashtab] Patch tx history rendering of NFT Collection genesis txs
ClosedPublic
Actions

Authored by bytesofman on Apr 26 2024, 12:16.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC93fcf7f22d88: [Cashtab] Patch tx history rendering of NFT Collection genesis txs

Summary

NFT Collection genesis txs are being rendered incorrectly as 0-output fan-out txs. Patch and confirm with tests.

Test Plan

npm test

Before this diff:

After this diff:

Diff Detail

Repository

rABC Bitcoin ABC

Branch

tx-history-fan-fix

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28764
Build 57066: Build Diff	cashtab-tests
Build 57065: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 26 2024, 12:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 26 2024, 12:16

bytesofman published this revision for review.Apr 26 2024, 12:17

bytesofman edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B28764: Diff 47439.Apr 26 2024, 12:19

emack accepted this revision.Apr 27 2024, 13:55

This revision is now accepted and ready to land.Apr 27 2024, 13:55

Closed by commit rABC93fcf7f22d88: [Cashtab] Patch tx history rendering of NFT Collection genesis txs (authored by bytesofman). · Explain WhyApr 27 2024, 14:02

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC93fcf7f22d88: [Cashtab] Patch tx history rendering of NFT Collection genesis txs.

Revision Contents
Changeset List

Path

Size

cashtab/

src/

chronik/

fixtures/

mocks.js

134 lines

vectors.js

7 lines

components/

Home/

Tx/

__tests__/

index.test.js

65 lines

index.js

2 lines

Diff 47439

View Options

cashtab/src/chronik/fixtures/mocks.js

View Options

cashtab/src/chronik/fixtures/vectors.js

View Options

cashtab/src/components/Home/Tx/tests/index.test.js

View Options

cashtab/src/components/Home/Tx/index.js

[Cashtab] Patch tx history rendering of NFT Collection genesis txsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47439

cashtab/src/chronik/fixtures/mocks.js

cashtab/src/chronik/fixtures/vectors.js

cashtab/src/components/Home/Tx/__tests__/index.test.js

cashtab/src/components/Home/Tx/index.js

[Cashtab] Patch tx history rendering of NFT Collection genesis txs
ClosedPublic
Actions

Revision Contents
Changeset List

cashtab/src/components/Home/Tx/tests/index.test.js