[Cashtab] Patch bug caused by wallet change from Tokens page
ClosedPublic
Actions

Authored by bytesofman on Apr 29 2024, 21:33.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC74d647d0b05c: [Cashtab] Patch bug caused by wallet change from Tokens page

Summary

The screen defines tokens as wallet.state.tokens in one place, uses this value to do the calculations, but then triggers the useEffect on wallet.state.tokens.

Make sure the tokens used in the useEffect is the same tokens used in the dependency array.

Test Plan

npm test, npm start, navigate to tokens page, change wallets a few times, no white screen app crash

Diff Detail

Repository

rABC Bitcoin ABC

Branch

handle-wallet-change-etokens

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28799
Build 57136: Build Diff	cashtab-tests
Build 57135: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 29 2024, 21:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 29 2024, 21:33

bytesofman published this revision for review.Apr 29 2024, 21:34

Harbormaster completed remote builds in B28799: Diff 47491.Apr 29 2024, 21:37

PiRK accepted this revision.Apr 30 2024, 06:34

This revision is now accepted and ready to land.Apr 30 2024, 06:34

Closed by commit rABC74d647d0b05c: [Cashtab] Patch bug caused by wallet change from Tokens page (authored by bytesofman). · Explain WhyApr 30 2024, 13:13

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC74d647d0b05c: [Cashtab] Patch bug caused by wallet change from Tokens page.

Revision Contents
Changeset List

Path

Size

cashtab/

src/

components/

Etokens/

Etokens.js

2 lines

Diff 47491

View Options

cashtab/src/components/Etokens/Etokens.js

[Cashtab] Patch bug caused by wallet change from Tokens pageClosedPublicActions