Page MenuHomePhabricator
Differential D1711

Remove use of the Amount constructor taking satoshi as input in all headers
ClosedPublic
Actions

Authored by deadalnix on Sep 4 2018, 15:49.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING906d603e083d: Remove use of the Amount constructor taking satoshi as input in all headers
rABC906d603e083d: Remove use of the Amount constructor taking satoshi as input in all headers
Summary

As per title.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
satheader
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3201
Build 4489: Bitcoin ABC Buildbot (legacy)
Build 4488: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 4 2018, 15:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 4 2018, 15:49
teamcity added a subscriber: teamcity.Sep 4 2018, 15:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 4 2018, 15:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3181: Diff 4741!Sep 4 2018, 15:53
deadalnix updated this revision to Diff 4753.Sep 4 2018, 17:53

rebase

teamcity added a comment.Sep 4 2018, 18:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 4 2018, 18:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3187: Diff 4753!Sep 4 2018, 18:16
deadalnix added a child revision: D1723: Make the constructor taking satoshi as parameter from the Amount class private.Sep 5 2018, 14:28
jasonbcox accepted this revision.Sep 5 2018, 16:51
This revision is now accepted and ready to land.Sep 5 2018, 16:51
deadalnix retitled this revision from Remove use of teh Amount constructor taking satoshi as input in all headers to Remove use of the Amount constructor taking satoshi as input in all headers.Sep 5 2018, 18:26
deadalnix updated this revision to Diff 4772.Sep 5 2018, 18:34

rebase

teamcity added a comment.Sep 5 2018, 18:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 5 2018, 18:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3201: Diff 4772!Sep 5 2018, 18:39
deadalnix updated this revision to Diff 4779.Sep 6 2018, 10:32

rebase

teamcity added a comment.Sep 6 2018, 10:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 6 2018, 10:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3204: Diff 4779!Sep 6 2018, 10:38
deadalnix updated this revision to Diff 4781.Sep 6 2018, 11:15

Make SATOSHI/CASH/CENT/COIN constexpr

teamcity added a comment.Sep 6 2018, 11:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 6 2018, 11:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3206: Diff 4781.Sep 6 2018, 11:53
Closed by commit rABC906d603e083d: Remove use of the Amount constructor taking satoshi as input in all headers (authored by deadalnix). · Explain WhySep 6 2018, 12:47
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
9 lines
policy/
4 lines
4 lines
qt/
2 lines
test/
2 lines
6 lines
wallet/
10 lines

Diff 4772

View Options

src/feerate.h

Loading...
View Options

src/policy/fees.h

Loading...
View Options

src/policy/policy.h

Loading...
View Options

src/qt/walletmodel.h

Loading...
View Options

src/test/test_bitcoin.h

Loading...
View Options

src/validation.h

Loading...
View Options

src/wallet/wallet.h

Loading...