Address latest observed CI failure for npm publication of ecash-lib
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABC61d6e0071709: [ecash-lib] Copy chronik to docker image
docker build -f ecash-lib.Dockerfile -t ecash-lib_local .
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- ecash-lib-ci-next-patch
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 28992 Build 57521: Build Diff Build 57520: arc lint + arc unit
Event Timeline
Comment Actions
You had the same test plan in D16131, how come it didn't work ? Did you run your test plan ?
Comment Actions
It is passing locally but so were the previous diffs
On reflection, it's probably that they just happen to pass locally because wasm happens to be already built locally. Will check this out
Comment Actions
I was not able to repeat the failure observed in CI locally, so I could still be missing something.
However, the failure in CI coems from chronik dir not being in place when ./build-wasm is run -- so it makes sense this should be changed
Potentially there is still some difference between the CI I have set up for this build step and the local test plan that I will need to troubleshoot in CI