Paths

Table of Contentst

Differential D16155

Move random test util code from setup_common to random
ClosedPublic
Actions

Authored by PiRK on May 14 2024, 13:24.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC4d970e2fdeef: Move random test util code from setup_common to random

Summary

as many of the unit tests don't use this code

This is a backport of core#26940 (partial) and core#27425
https://github.com/bitcoin/bitcoin/pull/26940/commits/81f5ade2a324167c03c5ce765a26bd42ed652723

This is a depency of core#25325

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28998
Build 57533: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 57532: arc lint + arc unit

Event Timeline

PiRK created this revision.May 14 2024, 13:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2024, 13:24

PiRK requested review of this revision.May 14 2024, 13:24

teamcity edited the summary of this revision. (Show Details)May 14 2024, 13:24

PiRK added a child revision: D16156: test: Create InsecureRandMoneyAmount() helper, de-duplicate add_coin methods.May 14 2024, 13:26

Harbormaster completed remote builds in B28998: Diff 47768.May 14 2024, 14:07

Fabien accepted this revision.May 15 2024, 11:46

This revision is now accepted and ready to land.May 15 2024, 11:46

Closed by commit rABC4d970e2fdeef: Move random test util code from setup_common to random (authored by PiRK). · Explain WhyMay 16 2024, 11:57

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC4d970e2fdeef: Move random test util code from setup_common to random.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

peermanager_tests.cpp

1 line

proof_tests.cpp

1 line

proofpool_tests.cpp

1 line

voterecord_tests.cpp

1 line

pow/

test/

aserti32d_tests.cpp

1 line

eda_tests.cpp

1 line

test/

1 line

1 line

1 line

1 line

blockencodings_tests.cpp

1 line

bloom_tests.cpp

1 line

cashaddrenc_tests.cpp

1 line

checkqueue_tests.cpp

1 line

coins_tests.cpp

1 line

crypto_tests.cpp

1 line

cuckoocache_tests.cpp

1 line

dbwrapper_tests.cpp

1 line

denialofservice_tests.cpp

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

transaction_tests.cpp

1 line

txpackage_tests.cpp

1 line

txrequest_tests.cpp

1 line

undo_tests.cpp

1 line

util/

65 lines

41 lines

54 lines

30 lines

1 line

validation_block_tests.cpp

1 line

validation_chainstate_tests.cpp

1 line

validation_chainstatemanager_tests.cpp

1 line

validation_flush_tests.cpp

1 line

wallet/

test/

wallet_crypto_tests.cpp

1 line

Diff 47768

View Options

src/avalanche/test/peermanager_tests.cpp

View Options

src/avalanche/test/proof_tests.cpp

View Options

src/avalanche/test/proofpool_tests.cpp

View Options

src/avalanche/test/voterecord_tests.cpp

View Options

src/pow/test/aserti32d_tests.cpp

View Options

src/pow/test/eda_tests.cpp

View Options

src/test/CMakeLists.txt

View Options

src/test/base58_tests.cpp

View Options

src/test/bitmanip_tests.cpp

View Options

src/test/blockcheck_tests.cpp

View Options

src/test/blockencodings_tests.cpp

View Options

src/test/bloom_tests.cpp

View Options

src/test/cashaddrenc_tests.cpp

View Options

src/test/checkqueue_tests.cpp

View Options

src/test/coins_tests.cpp

View Options

src/test/crypto_tests.cpp

View Options

src/test/cuckoocache_tests.cpp

View Options

src/test/dbwrapper_tests.cpp

View Options

src/test/denialofservice_tests.cpp

View Options

src/test/hash_tests.cpp

View Options

src/test/merkle_tests.cpp

View Options

src/test/miner_tests.cpp

View Options

src/test/pmt_tests.cpp

View Options

src/test/prevector_tests.cpp

View Options

src/test/random_tests.cpp

View Options

src/test/script_tests.cpp

View Options

src/test/sighash_tests.cpp

View Options

src/test/skiplist_tests.cpp

View Options

src/test/streams_tests.cpp

View Options

src/test/transaction_tests.cpp

View Options

src/test/txpackage_tests.cpp

View Options

src/test/txrequest_tests.cpp

View Options

src/test/undo_tests.cpp

View Options

src/test/util/random.h

View Options

src/test/util/random.cpp

View Options

src/test/util/setup_common.h

View Options

src/test/util/setup_common.cpp

View Options

src/test/util_tests.cpp

View Options

src/test/validation_block_tests.cpp

View Options

src/test/validation_chainstate_tests.cpp

View Options

src/test/validation_chainstatemanager_tests.cpp

View Options

src/test/validation_flush_tests.cpp

View Options

src/wallet/test/wallet_crypto_tests.cpp

Move random test util code from setup_common to randomClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47768

src/avalanche/test/peermanager_tests.cpp

src/avalanche/test/proof_tests.cpp

src/avalanche/test/proofpool_tests.cpp

src/avalanche/test/voterecord_tests.cpp

src/pow/test/aserti32d_tests.cpp

src/pow/test/eda_tests.cpp

src/test/CMakeLists.txt

src/test/base58_tests.cpp

src/test/bitmanip_tests.cpp

src/test/blockcheck_tests.cpp

src/test/blockencodings_tests.cpp

src/test/bloom_tests.cpp

src/test/cashaddrenc_tests.cpp

src/test/checkqueue_tests.cpp

src/test/coins_tests.cpp

src/test/crypto_tests.cpp

src/test/cuckoocache_tests.cpp

src/test/dbwrapper_tests.cpp

src/test/denialofservice_tests.cpp

src/test/hash_tests.cpp

src/test/merkle_tests.cpp

src/test/miner_tests.cpp

src/test/pmt_tests.cpp

src/test/prevector_tests.cpp

src/test/random_tests.cpp

src/test/script_tests.cpp

src/test/sighash_tests.cpp

src/test/skiplist_tests.cpp

src/test/streams_tests.cpp

src/test/transaction_tests.cpp

src/test/txpackage_tests.cpp

src/test/txrequest_tests.cpp

src/test/undo_tests.cpp

src/test/util/random.h

src/test/util/random.cpp

src/test/util/setup_common.h

src/test/util/setup_common.cpp

src/test/util_tests.cpp

src/test/validation_block_tests.cpp

src/test/validation_chainstate_tests.cpp

src/test/validation_chainstatemanager_tests.cpp

src/test/validation_flush_tests.cpp

src/wallet/test/wallet_crypto_tests.cpp

Move random test util code from setup_common to random
ClosedPublic
Actions

Revision Contents
Changeset List