Use TxId in CTxMemPool::UpdateTransactionsFromBlock
ClosedPublic
Actions

Authored by deadalnix on Sep 5 2018, 18:55.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGc925482ef0b2: Use TxId in CTxMemPool::UpdateTransactionsFromBlock
rABCc925482ef0b2: Use TxId in CTxMemPool::UpdateTransactionsFromBlock

Summary

As per title

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

txmempooltxid

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3205
Build 4497: Bitcoin ABC Buildbot (legacy)
Build 4496: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 5 2018, 18:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 5 2018, 18:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3203: Diff 4776.Sep 5 2018, 19:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox requested changes to this revision.Sep 5 2018, 22:25

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/txmempool.cpp
130 ↗	(On Diff #4776)	hashesToUpdate -> txidsToUpdate
src/txmempool.h
637 ↗	(On Diff #4776)	three instances of hashesToUpdate -> txidsToUpdate

This revision now requires changes to proceed.Sep 5 2018, 22:25

Fix various comments

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3205: Diff 4780.Sep 6 2018, 11:23

jasonbcox accepted this revision.Sep 6 2018, 16:31

This revision is now accepted and ready to land.Sep 6 2018, 16:31

Closed by commit rABCc925482ef0b2: Use TxId in CTxMemPool::UpdateTransactionsFromBlock (authored by deadalnix). · Explain WhySep 6 2018, 16:32

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

txmempool.h

15 lines

txmempool.cpp

38 lines

Diff 4780

View Options

src/txmempool.h