Differential D16191

Consistently delete nodes at the end of the net tests
ClosedPublic
Actions

Authored by Fabien on May 21 2024, 13:56.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC5bf917094e3d: Consistently delete nodes at the end of the net tests

Summary

Make sure there is no memory leakage from CConmanTest.

Test Plan

ninja check-bitcoin-net_tests

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_net_tests

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29048
Build 57632: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 57631: arc lint + arc unit

Event Timeline

Fabien created this revision.May 21 2024, 13:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 21 2024, 13:56

@bot build-linux64

teamcity awarded a token.May 21 2024, 13:57

Harbormaster completed remote builds in B29048: Diff 47847.May 21 2024, 14:15

Fabien published this revision for review.May 21 2024, 14:18

PiRK accepted this revision.May 21 2024, 14:36

This revision is now accepted and ready to land.May 21 2024, 14:36

Closed by commit rABC5bf917094e3d: Consistently delete nodes at the end of the net tests (authored by Fabien). · Explain WhyMay 21 2024, 14:38

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC5bf917094e3d: Consistently delete nodes at the end of the net tests.

Revision Contents
Changeset List

Path

Size

src/

test/

net_tests.cpp

5 lines

Diff 47847

View Options

Consistently delete nodes at the end of the net testsClosedPublicActions