Differential D16253

RPC: make RPCResult::MatchesType return useful errors
ClosedPublic
Actions

Authored by Fabien on May 30 2024, 09:08.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCf511f93f63f7: RPC: make RPCResult::MatchesType return useful errors

Summary

Currently if you don't correctly update the description of the return value for an RPC call, you essentially just get an assertion failure with no useful information; this generates a description of the problems instead.

Backport of core#26887.

Contains a layout leftover from D16252.

Depends on D16252.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR26887

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29175
Build 57886: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 57885: arc lint + arc unit

Event Timeline

Fabien created this revision.May 30 2024, 09:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 30 2024, 09:08

Fabien requested review of this revision.May 30 2024, 09:08

teamcity edited the summary of this revision. (Show Details)May 30 2024, 09:08

Harbormaster completed remote builds in B29174: Diff 48038.May 30 2024, 10:14

PiRK requested changes to this revision.May 30 2024, 11:26

PiRK added a subscriber: PiRK.

PiRK added inline comments.

src/rpc/util.cpp
1040–1041 ↗	(On Diff #48038)	This differs from the source material. Mistake in merge conflict resolution? You may be returning true even though you potentially pushed errors just above.