[Cashtab] Remove "webapp tx request" warning
ClosedPublic
Actions

Authored by bytesofman on Jun 11 2024, 18:42.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABCf69ab9380f0f: [Cashtab] Remove "webapp tx request" warning

Summary

Intention of this warning is that anyone could make a link that populates a tx into Cashtab.

We should show where the tx is coming from. However, this is non-trivial to do in a way that is itself immune from spoofing.

At the moment we are fighting a hypothetical problem. We do not know if the warning is effective. We do know that it is unsightly.

As with many crypto issues, with great power comes great responsibility. For Cashtab, smoother UX is always more important than security theater.

We do not have any specific examples of a user who was "saved" by this warning, which does not prevent the user from completing a tx anyway. So, get rid of it.

Test Plan

npm test
npm run extension, use the local extension and note absence of warning

Diff Detail

Repository

rABC Bitcoin ABC

Branch

webapp-tx-req-fix

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29281
Build 58098: Build Diff	cashtab-tests · ecash-lib-tests
Build 58097: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jun 11 2024, 18:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 11 2024, 18:42

Harbormaster completed remote builds in B29280: Diff 48215.Jun 11 2024, 18:42

lint

bytesofman published this revision for review.Jun 11 2024, 18:43

bytesofman edited the test plan for this revision. (Show Details)

Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Tail of the build log:

   Compiling quote v1.0.36
   Compiling syn v2.0.58
   Compiling secp256k1-sys-abc v0.4.1 (https://github.com/raipay/secp256k1-abc?rev=b23e742#b23e7421)
   Compiling crypto-common v0.1.6
   Compiling block-buffer v0.10.4
   Compiling digest v0.10.7
   Compiling sha2 v0.10.8
   Compiling ripemd v0.1.3
   Compiling wasm-bindgen-backend v0.2.92
   Compiling secp256k1-abc v0.20.3 (https://github.com/raipay/secp256k1-abc?rev=b23e742#b23e7421)
   Compiling thiserror-impl v1.0.58
   Compiling wasm-bindgen-macro-support v0.2.92
   Compiling wasm-bindgen-macro v0.2.92
   Compiling ecash-lib-wasm v0.1.0 (/work/modules/ecash-lib-wasm)
    Finished release-wasm [optimized] target(s) in 5.78s
/work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests

added 362 packages, and audited 364 packages in 2s

60 packages are looking for funding
  run `npm fund` for details

1 high severity vulnerability

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> ecash-lib@0.1.1 build
> tsc && tsc -p ./tsconfig.build.json && cp -r ./src/ffi ./dist

/work/cashtab /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests

added 1641 packages, and audited 2458 packages in 23s

292 packages are looking for funding
  run `npm fund` for details

4 vulnerabilities (3 moderate, 1 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> cashtab@2.40.1 build
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

[eslint] 
src/components/Send/SendXec.js
  Line 85:7:  'AppCreatedTxSummary' is assigned a value but never used  no-unused-vars

Search for the keywords to learn more about each error.


Build cashtab-tests failed with exit code 1

Harbormaster completed remote builds in B29281: Diff 48216.Jun 11 2024, 18:46

emack accepted this revision.Jun 12 2024, 01:43

This revision is now accepted and ready to land.Jun 12 2024, 01:43

Closed by commit rABCf69ab9380f0f: [Cashtab] Remove "webapp tx request" warning (authored by bytesofman). · Explain WhyJun 12 2024, 02:25

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCf69ab9380f0f: [Cashtab] Remove "webapp tx request" warning.