Paths

Table of Contentst

[ecashaddrjs] Fix types for `isValidCashAddress`
ClosedPublic
Actions

Authored by andreazllin on Jun 13 2024, 22:40.

Details

Reviewers

bytesofman
Fabien

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC481fcc4e5ce1: [ecashaddrjs] Fix types for `isValidCashAddress`

Summary

TypeScript gives an error when optionalPrefix in not defined when calling isValidCashAddress, this PR allows both undefined or explicit false for no prefixes, or a user passed string as prefix

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29294
Build 58124: Build Diff	ecashaddrjs-tests
Build 58123: arc lint + arc unit

Event Timeline

andreazllin created this revision.Jun 13 2024, 22:40

Owners added a reviewer: Restricted Owners Package.Jun 13 2024, 22:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 13 2024, 22:40

andreazllin requested review of this revision.Jun 13 2024, 22:40

Harbormaster completed remote builds in B29294: Diff 48238.Jun 13 2024, 22:42

andreazllin edited the test plan for this revision. (Show Details)Jun 13 2024, 22:58

andreazllin edited the summary of this revision. (Show Details)Jun 13 2024, 23:09

andreazllin edited the summary of this revision. (Show Details)

nice, thanks!

please

run npm version patch to bump the version number
update README.md #### Changelog section to describe the change

and will get this in

This revision now requires changes to proceed.Jun 13 2024, 23:33

Update package version
Add version to README.md Changelog

Harbormaster completed remote builds in B29297: Diff 48241.Jun 14 2024, 08:35

bytesofman accepted this revision.Jun 14 2024, 12:42

This revision is now accepted and ready to land.Jun 14 2024, 12:42

You can ping me on Telegram @bytesofman if you need support for landing this diff 🙏

Closed by commit rABC481fcc4e5ce1: [ecashaddrjs] Fix types for `isValidCashAddress` (authored by Andrea <andrea.lin3110@gmail.com>). · Explain WhyJun 16 2024, 17:28

This revision was automatically updated to reflect the committed changes.

Andrea <andrea.lin3110@gmail.com> added a commit: rABC481fcc4e5ce1: [ecashaddrjs] Fix types for `isValidCashAddress`.

Revision Contents
Changeset List

Path

Size

modules/

ecashaddrjs/

src/

cashaddr.d.ts

2 lines

Diff 48238

View Options

modules/ecashaddrjs/src/cashaddr.d.ts

[ecashaddrjs] Fix types for `isValidCashAddress`ClosedPublicActions