Differential D16337

[ecashaddrjs] Fix change log section of README
ClosedPublic
Actions

Authored by bytesofman on Jun 17 2024, 10:29.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCd43ea4a3c8e6: [ecashaddrjs] Fix change log section of README

Summary

1.5.5. was accidentally skipped in D15400

Correct this. Also match chronik-client style of change log by bulleting each version.

Test Plan

proofread

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ecashaddrjs-patch

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29313
Build 58162: Build Diff	ecashaddrjs-tests
Build 58161: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jun 17 2024, 10:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 17 2024, 10:29

Harbormaster completed remote builds in B29313: Diff 48259.Jun 17 2024, 10:31

bytesofman published this revision for review.Jun 17 2024, 10:56

Fabien requested changes to this revision.Jun 17 2024, 14:21

Fabien added a subscriber: Fabien.

Fabien added inline comments.

modules/ecashaddrjs/README.md
157	That's wrong, 1.5.5 was skipped not 1.5.6

This revision now requires changes to proceed.Jun 17 2024, 14:21

fix version error

Harbormaster completed remote builds in B29320: Diff 48267.Jun 17 2024, 15:10

Fabien accepted this revision.Jun 17 2024, 18:25

This revision is now accepted and ready to land.Jun 17 2024, 18:25

Closed by commit rABCd43ea4a3c8e6: [ecashaddrjs] Fix change log section of README (authored by bytesofman). · Explain WhyJun 17 2024, 19:09

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCd43ea4a3c8e6: [ecashaddrjs] Fix change log section of README.

Revision Contents
Changeset List

Path

Size

modules/

ecashaddrjs/

README.md

31 lines

Diff 48259

View Options

modules/ecashaddrjs/README.md

[ecashaddrjs] Fix change log section of READMEClosedPublicActions