Differential D16338
[Cashtab] Deprecate (unimplemented) function for explicit slp1 burns Authored by bytesofman on Jun 17 2024, 10:33. Tags None Subscribers None
Details
Intended to implement this in special cases where the user wants to burn a token amount that matches a utxo amount, which is common-ish (happens for example when user wants to burn all). However, we don't really get any advantage from this. The legacy way of burning is indexed fine by chronik and is much more flexible (user may burn any amount). Deprecating here as it is not implemented and, since now there are no plans to implement it, does not make sense to upgrade to ecash-lib style. npm test
Diff Detail
Event TimelineComment Actions Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Tail of the build log: Compiling secp256k1-sys-abc v0.4.1 (https://github.com/raipay/secp256k1-abc?rev=b23e742#b23e7421)
Compiling block-buffer v0.10.4
Compiling crypto-common v0.1.6
Compiling digest v0.10.7
Compiling ripemd v0.1.3
Compiling sha2 v0.10.8
Compiling wasm-bindgen-backend v0.2.92
Compiling secp256k1-abc v0.20.3 (https://github.com/raipay/secp256k1-abc?rev=b23e742#b23e7421)
Compiling thiserror-impl v1.0.58
Compiling wasm-bindgen-macro-support v0.2.92
Compiling wasm-bindgen-macro v0.2.92
Compiling ecash-lib-wasm v0.1.0 (/work/modules/ecash-lib-wasm)
Finished release-wasm [optimized] target(s) in 6.02s
/work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests
added 362 packages, and audited 364 packages in 2s
60 packages are looking for funding
run `npm fund` for details
1 high severity vulnerability
To address all issues, run:
npm audit fix
Run `npm audit` for details.
> ecash-lib@0.1.1 build
> tsc && tsc -p ./tsconfig.build.json && cp -r ./src/ffi ./dist
/work/cashtab /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests
added 1641 packages, and audited 2458 packages in 23s
292 packages are looking for funding
run `npm fund` for details
4 vulnerabilities (3 moderate, 1 high)
To address all issues, run:
npm audit fix
Run `npm audit` for details.
> cashtab@2.40.3 build
> node scripts/build.js
Creating an optimized production build...
Failed to compile.
[eslint]
src/slpv1/index.js
Line 7:10: 'initializeScript' is defined but never used no-unused-vars
Line 8:10: 'opReturn' is defined but never used no-unused-vars
Line 9:13: 'utxolib' is defined but never used no-unused-vars
Search for the keywords to learn more about each error.
Build cashtab-tests failed with exit code 1 |