Page MenuHomePhabricator

[Cashtab] Improve target output generation tests
ClosedPublic

Authored by bytesofman on Jun 17 2024, 10:56.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC59b1ef875c5a: [Cashtab] Improve target output generation tests
Summary

Depends on D16339

When tests were written, did not have a good solution to the problem of "cannot store Buffer in mocks." So, tests were designed to fit around imagined restriction of "mocks should only be the hex string."

This led to complicated tests and even some missed cases as functions were improved.

Refactor tests so that we are exactly matching mocks.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
improve-output-tests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29318
Build 58172: Build Diffcashtab-tests · ecash-lib-tests
Build 58171: arc lint + arc unit