Differential D16359

[electrum] print a less alarming error when the wrong app is open on a Ledger device
ClosedPublic
Actions

Authored by PiRK on Jun 20 2024, 16:13.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC5a4cbddd8c97: [electrum] print a less alarming error when the wrong app is open on a Ledger…

Summary

Previously if the ETH app was open on the device when opening the wallet, client.get_xpub -> client.checkDevice() in force_pair_xpub would raise a RuntimeError, which would be caught and cause the following alarming DeviceUnpairableError to be printed in a dialog. Raise a new custom DeviceNotInBitcoinCashModeError instead with a more helpful message, as we now what the cause of the issue is.

And when the BTC app was open, an unhelpful "Exception: Invalid status 6e00" dialog would show up. Handle this as well with the same error.

If the status is 0c6D00, it could also be caused by a compatibility issue with a newer firmware or BCH app version. In that case, print the full error message.

Test Plan

Try the various scenarios described above, check the usefulness of the error message

Diff Detail

Repository

rABC Bitcoin ABC

Branch

status_errorswq

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29362
Build 58260: Build Diff	electrum-tests
Build 58259: arc lint + arc unit

Event Timeline

PiRK created this revision.Jun 20 2024, 16:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 20 2024, 16:13

PiRK requested review of this revision.Jun 20 2024, 16:13

Harbormaster completed remote builds in B29362: Diff 48334.Jun 20 2024, 16:15

Fabien added a subscriber: Fabien.Jun 20 2024, 16:49

Fabien added inline comments.

electrum/electrumabc_plugins/ledger/ledger.py
310	0x6D00 can be raised for unknown commands, so upon ledger app update that is not under our control. In this case the message would be wrong as it's correctly using the BCH app