Differential D1756

make CNode::id private
ClosedPublic
Actions

Authored by deadalnix on Sep 10 2018, 17:39.

Details

Reviewers

schancel

Group Reviewers

Restricted Project

Commits

rSTAGING4bc3457d0c78: make CNode::id private
rABC4bc3457d0c78: make CNode::id private

Summary

This is similar in spirit to Core PR10189 but not a backport as it was simpler to simply redo it.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

corepr10189

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3252
Build 4591: Bitcoin ABC Buildbot (legacy)
Build 4590: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 10 2018, 17:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 10 2018, 17:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added a child revision: D1757: rpc: Add listen address to incoming connections in `getpeerinfo`.Sep 10 2018, 17:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3252: Diff 4845.Sep 10 2018, 18:15

schancel accepted this revision.Sep 10 2018, 20:56

This revision is now accepted and ready to land.Sep 10 2018, 20:56

Closed by commit rABC4bc3457d0c78: make CNode::id private (authored by deadalnix). · Explain WhySep 10 2018, 21:51

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

net.h

2 lines

net.cpp

15 lines

net_processing.cpp

112 lines

Diff 4845

View Options

src/net.h

View Options

src/net.cpp

View Options

make CNode::id privateClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 4845

src/net.h

src/net.cpp

src/net_processing.cpp

make CNode::id private
ClosedPublic
Actions

Revision Contents
Changeset List