Page MenuHomePhabricator
Differential D16411

test: MiniWallet: fix fee calculation for P2PK and check tx size
ClosedPublic
Actions

Authored by Fabien on Jul 3 2024, 09:15.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC084d081b193e: test: MiniWallet: fix fee calculation for P2PK and check tx size
Summary

Backport of core#22089.

Instead of the retry loop to get a fixed DER signature size, we could use the Schnorr signatures which are fixed size.
However the only test that uses the P2PK mode so far is the DER signature test, and using schnorr would invalidate the test.

Test Plan
ninja check-functional

Diff Detail

Event Timeline

Fabien created this revision.Jul 3 2024, 09:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 3 2024, 09:15
Fabien requested review of this revision.Jul 3 2024, 09:15
teamcity edited the summary of this revision. (Show Details)Jul 3 2024, 09:15
PiRK accepted this revision.Jul 3 2024, 09:25
PiRK added a subscriber: PiRK.
PiRK added inline comments.
test/functional/test_framework/wallet.py
148–152

This would look a bit nicer, but on the other hand deviation from the source material can be confusing.
Your call.

This revision is now accepted and ready to land.Jul 3 2024, 09:25
Harbormaster completed remote builds in B29455: Diff 48478.Jul 3 2024, 09:37
Fabien added inline comments.Jul 3 2024, 09:43
test/functional/test_framework/wallet.py
148–152

I don't think it's a big win. I would rather remove this code and use schnorr to get fixed size signature with no loop at all

Closed by commit rABC084d081b193e: test: MiniWallet: fix fee calculation for P2PK and check tx size (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by Fabien). · Explain WhyJul 3 2024, 09:58
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC084d081b193e: test: MiniWallet: fix fee calculation for P2PK and check tx size.

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
31 lines

Diff 48478

View Options

test/functional/test_framework/wallet.py

Loading...