Differential D16424

test: refactor RPCPackagesTest to use MiniWallet
ClosedPublic
Actions

Authored by Fabien on Jul 4 2024, 16:20.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC46df4c624317: test: refactor RPCPackagesTest to use MiniWallet

Summary

This PR refactors RPCPackagesTest to use MiniWallet and removes create_child_with_parents, make_chain, and create_raw_chain from test_framework/wallet

Backport of core#25522, core#25379 and core#25986.

Because of the removal of create_raw_chain, the abc_mempool_chainedtx test is also converted to Miniwallet.

Test Plan

ninja check-functional-extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR25986

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29476
Build 58488: Build Diff	build-without-wallet · build-debug · build-diff · build-clang-tidy · build-clang
Build 58487: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 4 2024, 16:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 4 2024, 16:20

Fabien requested review of this revision.Jul 4 2024, 16:20

teamcity edited the summary of this revision. (Show Details)Jul 4 2024, 16:20

Harbormaster completed remote builds in B29476: Diff 48512.Jul 4 2024, 16:58

PiRK accepted this revision.Jul 5 2024, 08:27

This revision is now accepted and ready to land.Jul 5 2024, 08:27

Closed by commit rABC46df4c624317: test: refactor RPCPackagesTest to use MiniWallet (authored by Fabien). · Explain WhyJul 5 2024, 15:40

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC46df4c624317: test: refactor RPCPackagesTest to use MiniWallet.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_mempool_chainedtx.py

42 lines

rpc_packages.py

320 lines

test_framework/

200 lines

Diff 48512

test/functional/abc_mempool_chainedtx.py

Loading...

test/functional/rpc_packages.py

Loading...

test/functional/test_framework/wallet.py

Loading...