Differential D16443

test: use MiniWallet for mining_prioritisetransaction.py
ClosedPublic
Actions

Authored by Fabien on Jul 11 2024, 14:28.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC8a5202b62d2d: test: use MiniWallet for mining_prioritisetransaction.py

Summary

This PR enables one more of the non-wallet functional tests (mining_prioritisetransaction.py) to be run even with the Bitcoin Code wallet by using the MiniWallet instead, as proposed in #20078. Note that the adapted helper function create_lots_of_big_transactions is currently only used in this test, i.e. there was no need to change any others.

Backport of core#24839.

Note that the test is slightly modified due to D1587, as gettransaction cannot be used anymore.

Test Plan

./test/functional/test_runner.py mempool_limit mining_prioritisetransaction

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR24839

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29523
Build 58581: Build Diff	build-clang · build-debug · build-clang-tidy · build-diff · build-without-wallet
Build 58580: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 11 2024, 14:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 11 2024, 14:28

Fabien requested review of this revision.Jul 11 2024, 14:28

teamcity edited the summary of this revision. (Show Details)Jul 11 2024, 14:28

Harbormaster completed remote builds in B29523: Diff 48580.Jul 11 2024, 14:50

Fabien added a child revision: D16447: validation: fix coins disappearing mid-package evaluation.Jul 11 2024, 15:38

PiRK accepted this revision.Jul 11 2024, 15:51

This revision is now accepted and ready to land.Jul 11 2024, 15:51

Closed by commit rABC8a5202b62d2d: test: use MiniWallet for mining_prioritisetransaction.py (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by Fabien). · Explain WhyJul 12 2024, 08:56

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC8a5202b62d2d: test: use MiniWallet for mining_prioritisetransaction.py.

Revision Contents
Changeset List

Path

Size

test/

functional/

feature_pruning.py

3 lines

mempool_limit.py

15 lines

mining_prioritisetransaction.py

62 lines

test_framework/

37 lines

Diff 48580

test/functional/feature_pruning.py

Loading...

test/functional/mempool_limit.py

Loading...

test/functional/mining_prioritisetransaction.py

Loading...

test/functional/test_framework/util.py

Loading...