Differential D16480

Fix style nits in p2p_compactblocks, make it easier to debug
ClosedPublic
Actions

Authored by Fabien on Jul 16 2024, 13:29.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC29da2db59a44: Fix style nits in p2p_compactblocks, make it easier to debug

Summary

This diff fixes several nits found while doing D16474:

Use the block hash as hex string in assert_equal. This is a bit slower but the debug.log shows the hash as hex string so it's much easier to debug via combine_logs.py
Don't override the default timeout, this is uncessary and could introduce spurious failures
Consistently use make_conform_to_ctor
Fix a related but wrong comment in messages.py

Test Plan

./test/functional/test_runner.py p2p_compactblocks

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cleanup_p2p_compactblocks

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29581
Build 58697: Build Diff	build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 58696: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 16 2024, 13:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 16 2024, 13:29

Fabien requested review of this revision.Jul 16 2024, 13:29

Harbormaster completed remote builds in B29581: Diff 48664.Jul 16 2024, 14:10

PiRK accepted this revision.Jul 16 2024, 14:40

PiRK added a subscriber: PiRK.

PiRK added inline comments.

test/functional/p2p_compactblocks.py

818

Nice bugfix! This assertion would only fail for very low integers

>>> a = 0xdeadbeef
>>> 0xdeadbeef is a
<stdin>:1: SyntaxWarning: "is" with a literal. Did you mean "=="?
False
>>>
>>> a = 256
>>> 256 is a
<stdin>:1: SyntaxWarning: "is" with a literal. Did you mean "=="?
True
>>>
>>> a = 257
>>> 257 is a
<stdin>:1: SyntaxWarning: "is" with a literal. Did you mean "=="?
False

This revision is now accepted and ready to land.Jul 16 2024, 14:40

Closed by commit rABC29da2db59a44: Fix style nits in p2p_compactblocks, make it easier to debug (authored by Fabien). · Explain WhyJul 16 2024, 15:43

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC29da2db59a44: Fix style nits in p2p_compactblocks, make it easier to debug.