Differential D16485

test: Run feature_bip68_sequence.py with MiniWallet
ClosedPublic
Actions

Authored by Fabien on Jul 17 2024, 09:25.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC4a354dc7f54b: test: Run feature_bip68_sequence.py with MiniWallet

Summary

This PR enables one more of the non-wallet functional tests (feature_bip68_sequence.py) to be run even when no wallet is compiled in by using the MiniWallet instead

Completes backport of core#26657.

Test Plan

./test/functional/test_runner.py feature_bip68_sequence

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR26657

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29588
Build 58711: Build Diff	build-without-wallet · build-diff · build-clang · build-debug · build-clang-tidy
Build 58710: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 17 2024, 09:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 17 2024, 09:25

Fabien requested review of this revision.Jul 17 2024, 09:25

teamcity edited the summary of this revision. (Show Details)Jul 17 2024, 09:25

PiRK requested changes to this revision.Jul 17 2024, 09:42

PiRK added a subscriber: PiRK.

PiRK added inline comments.

test/functional/test_framework/wallet.py
152	remove now incorrect docstring

This revision now requires changes to proceed.Jul 17 2024, 09:42

Harbormaster completed remote builds in B29588: Diff 48675.Jul 17 2024, 09:47

Fix docstring

Harbormaster completed remote builds in B29589: Diff 48676.Jul 17 2024, 10:17

PiRK accepted this revision.Jul 17 2024, 12:29

This revision is now accepted and ready to land.Jul 17 2024, 12:29

Closed by commit rABC4a354dc7f54b: test: Run feature_bip68_sequence.py with MiniWallet (authored by Miles Liu <miles@bung.cc>, committed by Fabien). · Explain WhyJul 17 2024, 13:09

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC4a354dc7f54b: test: Run feature_bip68_sequence.py with MiniWallet.

Revision Contents
Changeset List

Path

Size

test/

functional/

feature_bip68_sequence.py

144 lines

test_framework/

75 lines

Diff 48675

test/functional/feature_bip68_sequence.py

Loading...

test/functional/test_framework/wallet.py

Loading...