Page MenuHomePhabricator
Differential D16486

Move fill_mempool to util function
ClosedPublic
Actions

Authored by Fabien on Jul 17 2024, 10:11.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCf7a23c763c00: Move fill_mempool to util function
Summary

This is a partial backport of core#29735, consisting of the first 3 commits.

The remaining parts of the PR fix a bug that has not been introduced (dependency not backported yet).

Test Plan
./test/functional/test_runner.py mempool_limit

Diff Detail

Repository
rABC Bitcoin ABC
Branch
move_fill_mempool_utils
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29592
Build 58719: Build Diffbuild-debug · build-clang-tidy · build-clang · build-without-wallet · build-diff
Build 58718: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 17 2024, 10:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 17 2024, 10:11
Fabien requested review of this revision.Jul 17 2024, 10:11
teamcity edited the summary of this revision. (Show Details)Jul 17 2024, 10:11
Harbormaster completed remote builds in B29590: Diff 48677.Jul 17 2024, 10:33
PiRK requested changes to this revision.Jul 17 2024, 12:52
PiRK added a subscriber: PiRK.
PiRK added inline comments.
test/functional/test_framework/util.py
555–556 ↗(On Diff #48677)

node and miniwallet are passed as function args, now, so no need to get them from the test_framework. And BitcoinTestFramework.wallet is not necessarily defined in general.

This revision now requires changes to proceed.Jul 17 2024, 12:52
Fabien updated this revision to Diff 48679.Jul 17 2024, 13:02

Remove the node and wallet assignment lines

Harbormaster completed remote builds in B29592: Diff 48679.Jul 17 2024, 13:25
PiRK accepted this revision.Jul 17 2024, 13:42
This revision is now accepted and ready to land.Jul 17 2024, 13:42
Closed by commit rABCf7a23c763c00: Move fill_mempool to util function (authored by Greg Sanders <gsanders87@gmail.com>, committed by Fabien). · Explain WhyJul 17 2024, 13:51
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCf7a23c763c00: Move fill_mempool to util function.

Revision Contents
Changeset List

PathSize
test/
functional/
62 lines
test_framework/
57 lines

Diff 48679

View Options

test/functional/mempool_limit.py

Loading...
View Options

test/functional/test_framework/util.py

Loading...