Differential D16501

refactor: Use type-safe time in txorphanage
ClosedPublic
Actions

Authored by Fabien on Jul 18 2024, 13:28.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCa53da9376411: refactor: Use type-safe time in txorphanage

Summary

This allows to remove manual conversions like multiplication by 60, and uses a type-safe type instead of a raw int64_t.

Backport of core#30170.

Depends on D16498.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 18 2024, 13:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 18 2024, 13:28

Fabien requested review of this revision.Jul 18 2024, 13:28

teamcity edited the summary of this revision. (Show Details)Jul 18 2024, 13:28

PiRK accepted this revision.Jul 18 2024, 14:29

This revision is now accepted and ready to land.Jul 18 2024, 14:29

Harbormaster completed remote builds in B29628: Diff 48728.Jul 18 2024, 14:36

Closed by commit rABCa53da9376411: refactor: Use type-safe time in txorphanage (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>, committed by Fabien). · Explain WhyJul 19 2024, 08:05

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCa53da9376411: refactor: Use type-safe time in txorphanage.

Revision Contents
Changeset List

Path

Size

src/

txorphanage.h

3 lines

txorphanage.cpp

19 lines

Diff 48733

View Options

src/txorphanage.h