Page MenuHomePhabricator
Differential D1773

Rename various variable so they do not shadow
ClosedPublic
Actions

Authored by deadalnix on Sep 12 2018, 13:23.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING6ad95c3bab28: Rename various variable so they do not shadow
rABC6ad95c3bab28: Rename various variable so they do not shadow
Summary

As per title, this also uncovered a problem in the RPC code when dumping help for each method.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fixshaddow
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3280
Build 4646: Bitcoin ABC Buildbot (legacy)
Build 4645: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 12 2018, 13:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 12 2018, 13:23
teamcity added a subscriber: teamcity.Sep 12 2018, 13:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 12 2018, 13:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3280: Diff 4893.Sep 12 2018, 13:58
schancel retitled this revision from Rename various variable so they do not shaddow to Rename various variable so they do not shadow.Sep 15 2018, 15:11
schancel edited the summary of this revision. (Show Details)
schancel accepted this revision.Sep 15 2018, 15:14
schancel added a subscriber: schancel.
schancel added inline comments.
src/rpc/server.cpp
226

Is this the problem that had been discovered?

src/script/sigcache.h
49

What are these things shadowing?

src/script/sign.h
58

Worst variable name ever.

This revision is now accepted and ready to land.Sep 15 2018, 15:14
Closed by commit rABC6ad95c3bab28: Rename various variable so they do not shadow (authored by deadalnix). · Explain WhySep 15 2018, 16:55
This revision was automatically updated to reflect the committed changes.
deadalnix added inline comments.Sep 15 2018, 16:56
src/rpc/server.cpp
226

Yes

src/script/sigcache.h
49

The amount field in the parent class

Revision Contents
Changeset List

PathSize
src/
5 lines
4 lines
rpc/
4 lines
2 lines
script/
5 lines
6 lines
5 lines
8 lines
wallet/
8 lines

Diff 4893

View Options

src/addrdb.cpp

Loading...
View Options

src/chain.h

Loading...
View Options

src/rpc/abc.cpp

Loading...
View Options

src/rpc/server.cpp

Loading...
View Options

src/script/interpreter.h

Loading...
View Options

src/script/sigcache.h

Loading...
View Options

src/script/sign.h

Loading...
View Options

src/txmempool.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...