Page MenuHomePhabricator

depends: build miniupnpc with CMake
ClosedPublic

Authored by Fabien on Jul 31 2024, 19:27.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCfb11627736ad: depends: build miniupnpc with CMake
Summary
This picks up one of the changes from #29232, which is a switch to building miniupnpc with CMake. It includes an update to the most recent version of miniupnpc (2.2.7), which means we can drop one patch from that commit, and includes a new patch for a change I've upstreamed miniupnp/miniupnp#721, as well as some suggestions from the previous PR.

Backport of core#29707.

Depends on D16567.

Test Plan

Run the GUIX builds.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR29707
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29813
Build 59161: Build Diff
Build 59160: arc lint + arc unit

Event Timeline

Fabien requested review of this revision.Jul 31 2024, 19:27

Fix merge issue in dependencies.md

@bot guix-linux guix-osx guix-win

Tail of the build log:

checking for library containing deflate... -lz
checking for library containing system... none required
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating sqlite3.pc
config.status: executing depfiles commands
config.status: executing libtool commands
Building sqlite...
make[1]: Entering directory '/bitcoin/depends/work/build/x86_64-apple-darwin/sqlite/3320100-40082b54cc6'
make[1]: warning: -j12 forced in submake: resetting jobserver mode.
/bin/sh ./libtool  --tag=CC   --mode=compile env -u C_INCLUDE_PATH -u CPLUS_INCLUDE_PATH -u OBJC_INCLUDE_PATH -u OBJCPLUS_INCLUDE_PATH -u CPATH -u LIBRARY_PATH /home/bitcoinabc/.guix-profile/bin/clang --target=x86_64-apple-darwin -mmacosx-version-min=10.15 -B/bitcoin/depends/x86_64-apple-darwin/native/bin -mlinker-version=609 -isysroot/bitcoin/depends/SDKs/Xcode-12.2-12B45b-extracted-SDK-with-libcxx-headers -nostdlibinc -iwithsysroot/usr/include -iframeworkwithsysroot/System/Library/Frameworks -DPACKAGE_NAME=\"sqlite\" -DPACKAGE_TARNAME=\"sqlite\" -DPACKAGE_VERSION=\"3.32.1\" -DPACKAGE_STRING=\"sqlite\ 3.32.1\" -DPACKAGE_BUGREPORT=\"http://www.sqlite.org\" -DPACKAGE_URL=\"\" -DPACKAGE=\"sqlite\" -DVERSION=\"3.32.1\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_FDATASYNC=1 -DHAVE_USLEEP=1 -DHAVE_LOCALTIME_R=1 -DHAVE_GMTIME_R=1 -DHAVE_DECL_STRERROR_R=1 -DHAVE_STRERROR_R=1 -DHAVE_EDITLINE_READLINE_H=1 -DHAVE_ZLIB_H=1 -I.   -I/bitcoin/depends/x86_64-apple-darwin/include -D_REENTRANT=1 -DSQLITE_THREADSAFE=1 -DSQLITE_OMIT_LOAD_EXTENSION=1 -DSQLITE_ENABLE_FTS4 -DSQLITE_ENABLE_FTS5 -DSQLITE_ENABLE_JSON1 -DSQLITE_ENABLE_RTREE -DSQLITE_ENABLE_GEOPOLY -DSQLITE_HAVE_ZLIB  -pipe -O2 -MT sqlite3.lo -MD -MP -MF .deps/sqlite3.Tpo -c -o sqlite3.lo sqlite3.c
libtool: compile:  env -u C_INCLUDE_PATH -u CPLUS_INCLUDE_PATH -u OBJC_INCLUDE_PATH -u OBJCPLUS_INCLUDE_PATH -u CPATH -u LIBRARY_PATH /home/bitcoinabc/.guix-profile/bin/clang --target=x86_64-apple-darwin -mmacosx-version-min=10.15 -B/bitcoin/depends/x86_64-apple-darwin/native/bin -mlinker-version=609 -isysroot/bitcoin/depends/SDKs/Xcode-12.2-12B45b-extracted-SDK-with-libcxx-headers -nostdlibinc -iwithsysroot/usr/include -iframeworkwithsysroot/System/Library/Frameworks -DPACKAGE_NAME=\"sqlite\" -DPACKAGE_TARNAME=\"sqlite\" -DPACKAGE_VERSION=\"3.32.1\" "-DPACKAGE_STRING=\"sqlite 3.32.1\"" -DPACKAGE_BUGREPORT=\"http://www.sqlite.org\" -DPACKAGE_URL=\"\" -DPACKAGE=\"sqlite\" -DVERSION=\"3.32.1\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_FDATASYNC=1 -DHAVE_USLEEP=1 -DHAVE_LOCALTIME_R=1 -DHAVE_GMTIME_R=1 -DHAVE_DECL_STRERROR_R=1 -DHAVE_STRERROR_R=1 -DHAVE_EDITLINE_READLINE_H=1 -DHAVE_ZLIB_H=1 -I. -I/bitcoin/depends/x86_64-apple-darwin/include -D_REENTRANT=1 -DSQLITE_THREADSAFE=1 -DSQLITE_OMIT_LOAD_EXTENSION=1 -DSQLITE_ENABLE_FTS4 -DSQLITE_ENABLE_FTS5 -DSQLITE_ENABLE_JSON1 -DSQLITE_ENABLE_RTREE -DSQLITE_ENABLE_GEOPOLY -DSQLITE_HAVE_ZLIB -pipe -O2 -MT sqlite3.lo -MD -MP -MF .deps/sqlite3.Tpo -c sqlite3.c -o sqlite3.o
mv -f .deps/sqlite3.Tpo .deps/sqlite3.Plo
/bin/sh ./libtool  --tag=CC   --mode=link env -u C_INCLUDE_PATH -u CPLUS_INCLUDE_PATH -u OBJC_INCLUDE_PATH -u OBJCPLUS_INCLUDE_PATH -u CPATH -u LIBRARY_PATH /home/bitcoinabc/.guix-profile/bin/clang --target=x86_64-apple-darwin -mmacosx-version-min=10.15 -B/bitcoin/depends/x86_64-apple-darwin/native/bin -mlinker-version=609 -isysroot/bitcoin/depends/SDKs/Xcode-12.2-12B45b-extracted-SDK-with-libcxx-headers -nostdlibinc -iwithsysroot/usr/include -iframeworkwithsysroot/System/Library/Frameworks -D_REENTRANT=1 -DSQLITE_THREADSAFE=1 -DSQLITE_OMIT_LOAD_EXTENSION=1 -DSQLITE_ENABLE_FTS4 -DSQLITE_ENABLE_FTS5 -DSQLITE_ENABLE_JSON1 -DSQLITE_ENABLE_RTREE -DSQLITE_ENABLE_GEOPOLY -DSQLITE_HAVE_ZLIB  -pipe -O2 -no-undefined -version-info 8:6:8 -L/bitcoin/depends/x86_64-apple-darwin/lib -o libsqlite3.la -rpath /bitcoin/depends/x86_64-apple-darwin/lib sqlite3.lo  -lz 
libtool: link: /bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-ar cru .libs/libsqlite3.a  sqlite3.o
libtool: link: /bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-ranlib .libs/libsqlite3.a
libtool: link: ( cd ".libs" && rm -f "libsqlite3.la" && ln -s "../libsqlite3.la" "libsqlite3.la" )
make[1]: Leaving directory '/bitcoin/depends/work/build/x86_64-apple-darwin/sqlite/3320100-40082b54cc6'
Staging sqlite...
make[1]: Entering directory '/bitcoin/depends/work/build/x86_64-apple-darwin/sqlite/3320100-40082b54cc6'
 /home/bitcoinabc/.guix-profile/bin/mkdir -p '/bitcoin/depends/work/staging/x86_64-apple-darwin/sqlite/3320100-40082b54cc6/bitcoin/depends/x86_64-apple-darwin/lib'
 /home/bitcoinabc/.guix-profile/bin/mkdir -p '/bitcoin/depends/work/staging/x86_64-apple-darwin/sqlite/3320100-40082b54cc6/bitcoin/depends/x86_64-apple-darwin/include'
 /home/bitcoinabc/.guix-profile/bin/mkdir -p '/bitcoin/depends/work/staging/x86_64-apple-darwin/sqlite/3320100-40082b54cc6/bitcoin/depends/x86_64-apple-darwin/lib/pkgconfig'
 /bin/sh ./libtool   --mode=install /home/bitcoinabc/.guix-profile/bin/install -c   libsqlite3.la '/bitcoin/depends/work/staging/x86_64-apple-darwin/sqlite/3320100-40082b54cc6/bitcoin/depends/x86_64-apple-darwin/lib'
 /home/bitcoinabc/.guix-profile/bin/install -c -m 644 sqlite3.h sqlite3ext.h '/bitcoin/depends/work/staging/x86_64-apple-darwin/sqlite/3320100-40082b54cc6/bitcoin/depends/x86_64-apple-darwin/include'
 /home/bitcoinabc/.guix-profile/bin/install -c -m 644 sqlite3.pc '/bitcoin/depends/work/staging/x86_64-apple-darwin/sqlite/3320100-40082b54cc6/bitcoin/depends/x86_64-apple-darwin/lib/pkgconfig'
libtool: install: /home/bitcoinabc/.guix-profile/bin/install -c .libs/libsqlite3.lai /bitcoin/depends/work/staging/x86_64-apple-darwin/sqlite/3320100-40082b54cc6/bitcoin/depends/x86_64-apple-darwin/lib/libsqlite3.la
libtool: install: /home/bitcoinabc/.guix-profile/bin/install -c .libs/libsqlite3.a /bitcoin/depends/work/staging/x86_64-apple-darwin/sqlite/3320100-40082b54cc6/bitcoin/depends/x86_64-apple-darwin/lib/libsqlite3.a
libtool: install: chmod 644 /bitcoin/depends/work/staging/x86_64-apple-darwin/sqlite/3320100-40082b54cc6/bitcoin/depends/x86_64-apple-darwin/lib/libsqlite3.a
libtool: install: /bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-ranlib /bitcoin/depends/work/staging/x86_64-apple-darwin/sqlite/3320100-40082b54cc6/bitcoin/depends/x86_64-apple-darwin/lib/libsqlite3.a
libtool: warning: remember to run 'libtool --finish /bitcoin/depends/x86_64-apple-darwin/lib'
make[1]: Leaving directory '/bitcoin/depends/work/build/x86_64-apple-darwin/sqlite/3320100-40082b54cc6'
Postprocessing sqlite...
Caching sqlite...
Extracting miniupnpc...
/bitcoin/depends/sources/miniupnpc-2.2.7.tar.gz: OK
Preprocessing miniupnpc...
patching file src/minisoap.c
patching file src/miniwget.c
patching file CMakeLists.txt
patching file src/win32_snprintf.h
Configuring miniupnpc...
-- The C compiler identification is Clang 10.0.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /home/bitcoinabc/.guix-profile/bin/env - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: /bitcoin/depends/work/build/x86_64-apple-darwin/miniupnpc/2.2.7-db27776de5d/build
Building miniupnpc...
make[1]: Entering directory '/bitcoin/depends/work/build/x86_64-apple-darwin/miniupnpc/2.2.7-db27776de5d/build'
make[1]: warning: -j12 forced in submake: resetting jobserver mode.
make[1]: *** No targets specified and no makefile found.  Stop.
make[1]: Leaving directory '/bitcoin/depends/work/build/x86_64-apple-darwin/miniupnpc/2.2.7-db27776de5d/build'
make: *** [funcs.mk:282: /bitcoin/depends/work/build/x86_64-apple-darwin/miniupnpc/2.2.7-db27776de5d/build/.stamp_built] Error 2
make: Leaving directory '/bitcoin/depends'
Build guix-osx failed with exit code 2

Tail of the build log:

Building sqlite...
make[1]: Entering directory '/bitcoin/depends/work/build/x86_64-w64-mingw32/sqlite/3320100-02c7b995aa5'
make[1]: warning: -j12 forced in submake: resetting jobserver mode.
/bin/sh ./libtool  --tag=CC   --mode=compile x86_64-w64-mingw32-gcc -DPACKAGE_NAME=\"sqlite\" -DPACKAGE_TARNAME=\"sqlite\" -DPACKAGE_VERSION=\"3.32.1\" -DPACKAGE_STRING=\"sqlite\ 3.32.1\" -DPACKAGE_BUGREPORT=\"http://www.sqlite.org\" -DPACKAGE_URL=\"\" -DPACKAGE=\"sqlite\" -DVERSION=\"3.32.1\" -D_FILE_OFFSET_BITS=64 -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_USLEEP=1 -DHAVE_DECL_STRERROR_R=0 -I.   -I/bitcoin/depends/x86_64-w64-mingw32/include -D_REENTRANT=1 -DSQLITE_THREADSAFE=1 -DSQLITE_OMIT_LOAD_EXTENSION=1 -DSQLITE_ENABLE_FTS4 -DSQLITE_ENABLE_FTS5 -DSQLITE_ENABLE_JSON1 -DSQLITE_ENABLE_RTREE -DSQLITE_ENABLE_GEOPOLY  -pipe -O2 -MT sqlite3.lo -MD -MP -MF .deps/sqlite3.Tpo -c -o sqlite3.lo sqlite3.c
libtool: compile:  x86_64-w64-mingw32-gcc -DPACKAGE_NAME=\"sqlite\" -DPACKAGE_TARNAME=\"sqlite\" -DPACKAGE_VERSION=\"3.32.1\" "-DPACKAGE_STRING=\"sqlite 3.32.1\"" -DPACKAGE_BUGREPORT=\"http://www.sqlite.org\" -DPACKAGE_URL=\"\" -DPACKAGE=\"sqlite\" -DVERSION=\"3.32.1\" -D_FILE_OFFSET_BITS=64 -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_USLEEP=1 -DHAVE_DECL_STRERROR_R=0 -I. -I/bitcoin/depends/x86_64-w64-mingw32/include -D_REENTRANT=1 -DSQLITE_THREADSAFE=1 -DSQLITE_OMIT_LOAD_EXTENSION=1 -DSQLITE_ENABLE_FTS4 -DSQLITE_ENABLE_FTS5 -DSQLITE_ENABLE_JSON1 -DSQLITE_ENABLE_RTREE -DSQLITE_ENABLE_GEOPOLY -pipe -O2 -MT sqlite3.lo -MD -MP -MF .deps/sqlite3.Tpo -c sqlite3.c -o sqlite3.o
sqlite3.c: In function 'sqlite3SelectNew':
sqlite3.c:129016:10: warning: function may return address of local variable [-Wreturn-local-addr]
129016 |   return pNew;
       |          ^~~~
sqlite3.c:128976:10: note: declared here
128976 |   Select standin;
       |          ^~~~~~~
mv -f .deps/sqlite3.Tpo .deps/sqlite3.Plo
/bin/sh ./libtool  --tag=CC   --mode=link x86_64-w64-mingw32-gcc -D_REENTRANT=1 -DSQLITE_THREADSAFE=1 -DSQLITE_OMIT_LOAD_EXTENSION=1 -DSQLITE_ENABLE_FTS4 -DSQLITE_ENABLE_FTS5 -DSQLITE_ENABLE_JSON1 -DSQLITE_ENABLE_RTREE -DSQLITE_ENABLE_GEOPOLY  -pipe -O2 -no-undefined -version-info 8:6:8 -L/bitcoin/depends/x86_64-w64-mingw32/lib -o libsqlite3.la -rpath /bitcoin/depends/x86_64-w64-mingw32/lib sqlite3.lo  
libtool: link: x86_64-w64-mingw32-ar cru .libs/libsqlite3.a  sqlite3.o
x86_64-w64-mingw32-ar: `u' modifier ignored since `D' is the default (see `U')
libtool: link: x86_64-w64-mingw32-ranlib .libs/libsqlite3.a
libtool: link: ( cd ".libs" && rm -f "libsqlite3.la" && ln -s "../libsqlite3.la" "libsqlite3.la" )
make[1]: Leaving directory '/bitcoin/depends/work/build/x86_64-w64-mingw32/sqlite/3320100-02c7b995aa5'
Staging sqlite...
make[1]: Entering directory '/bitcoin/depends/work/build/x86_64-w64-mingw32/sqlite/3320100-02c7b995aa5'
 /bin/mkdir -p '/bitcoin/depends/work/staging/x86_64-w64-mingw32/sqlite/3320100-02c7b995aa5/bitcoin/depends/x86_64-w64-mingw32/lib'
 /bin/mkdir -p '/bitcoin/depends/work/staging/x86_64-w64-mingw32/sqlite/3320100-02c7b995aa5/bitcoin/depends/x86_64-w64-mingw32/include'
 /bin/mkdir -p '/bitcoin/depends/work/staging/x86_64-w64-mingw32/sqlite/3320100-02c7b995aa5/bitcoin/depends/x86_64-w64-mingw32/lib/pkgconfig'
 /bin/sh ./libtool   --mode=install /bin/install -c   libsqlite3.la '/bitcoin/depends/work/staging/x86_64-w64-mingw32/sqlite/3320100-02c7b995aa5/bitcoin/depends/x86_64-w64-mingw32/lib'
 /bin/install -c -m 644 sqlite3.h sqlite3ext.h '/bitcoin/depends/work/staging/x86_64-w64-mingw32/sqlite/3320100-02c7b995aa5/bitcoin/depends/x86_64-w64-mingw32/include'
 /bin/install -c -m 644 sqlite3.pc '/bitcoin/depends/work/staging/x86_64-w64-mingw32/sqlite/3320100-02c7b995aa5/bitcoin/depends/x86_64-w64-mingw32/lib/pkgconfig'
libtool: install: /bin/install -c .libs/libsqlite3.lai /bitcoin/depends/work/staging/x86_64-w64-mingw32/sqlite/3320100-02c7b995aa5/bitcoin/depends/x86_64-w64-mingw32/lib/libsqlite3.la
libtool: install: /bin/install -c .libs/libsqlite3.a /bitcoin/depends/work/staging/x86_64-w64-mingw32/sqlite/3320100-02c7b995aa5/bitcoin/depends/x86_64-w64-mingw32/lib/libsqlite3.a
libtool: install: chmod 644 /bitcoin/depends/work/staging/x86_64-w64-mingw32/sqlite/3320100-02c7b995aa5/bitcoin/depends/x86_64-w64-mingw32/lib/libsqlite3.a
libtool: install: x86_64-w64-mingw32-ranlib /bitcoin/depends/work/staging/x86_64-w64-mingw32/sqlite/3320100-02c7b995aa5/bitcoin/depends/x86_64-w64-mingw32/lib/libsqlite3.a
libtool: warning: remember to run 'libtool --finish /bitcoin/depends/x86_64-w64-mingw32/lib'
make[1]: Leaving directory '/bitcoin/depends/work/build/x86_64-w64-mingw32/sqlite/3320100-02c7b995aa5'
Postprocessing sqlite...
Caching sqlite...
Extracting miniupnpc...
/bitcoin/depends/sources/miniupnpc-2.2.7.tar.gz: OK
Preprocessing miniupnpc...
patching file src/minisoap.c
patching file src/miniwget.c
patching file CMakeLists.txt
patching file src/win32_snprintf.h
Configuring miniupnpc...
-- The C compiler identification is GNU 10.5.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /bin/x86_64-w64-mingw32-gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: /bitcoin/depends/work/build/x86_64-w64-mingw32/miniupnpc/2.2.7-b9c01f80e2d/build
Building miniupnpc...
make[1]: Entering directory '/bitcoin/depends/work/build/x86_64-w64-mingw32/miniupnpc/2.2.7-b9c01f80e2d/build'
make[1]: warning: -j12 forced in submake: resetting jobserver mode.
make[1]: *** No targets specified and no makefile found.  Stop.
make[1]: Leaving directory '/bitcoin/depends/work/build/x86_64-w64-mingw32/miniupnpc/2.2.7-b9c01f80e2d/build'
make: *** [funcs.mk:282: /bitcoin/depends/work/build/x86_64-w64-mingw32/miniupnpc/2.2.7-b9c01f80e2d/build/.stamp_built] Error 2
make: Leaving directory '/bitcoin/depends'
Build guix-win failed with exit code 2

Tail of the build log:

Building sqlite...
make[1]: Entering directory '/bitcoin/depends/work/build/x86_64-linux-gnu/sqlite/3320100-67748321f63'
make[1]: warning: -j12 forced in submake: resetting jobserver mode.
/bin/sh ./libtool  --tag=CC   --mode=compile x86_64-linux-gnu-gcc -DPACKAGE_NAME=\"sqlite\" -DPACKAGE_TARNAME=\"sqlite\" -DPACKAGE_VERSION=\"3.32.1\" -DPACKAGE_STRING=\"sqlite\ 3.32.1\" -DPACKAGE_BUGREPORT=\"http://www.sqlite.org\" -DPACKAGE_URL=\"\" -DPACKAGE=\"sqlite\" -DVERSION=\"3.32.1\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_FDATASYNC=1 -DHAVE_USLEEP=1 -DHAVE_LOCALTIME_R=1 -DHAVE_GMTIME_R=1 -DHAVE_DECL_STRERROR_R=1 -DHAVE_STRERROR_R=1 -DHAVE_POSIX_FALLOCATE=1 -I.   -I/bitcoin/depends/x86_64-linux-gnu/include -D_REENTRANT=1 -DSQLITE_THREADSAFE=1 -DSQLITE_OMIT_LOAD_EXTENSION=1 -DSQLITE_ENABLE_FTS4 -DSQLITE_ENABLE_FTS5 -DSQLITE_ENABLE_JSON1 -DSQLITE_ENABLE_RTREE -DSQLITE_ENABLE_GEOPOLY  -pipe -O2 -MT sqlite3.lo -MD -MP -MF .deps/sqlite3.Tpo -c -o sqlite3.lo sqlite3.c
libtool: compile:  x86_64-linux-gnu-gcc -DPACKAGE_NAME=\"sqlite\" -DPACKAGE_TARNAME=\"sqlite\" -DPACKAGE_VERSION=\"3.32.1\" "-DPACKAGE_STRING=\"sqlite 3.32.1\"" -DPACKAGE_BUGREPORT=\"http://www.sqlite.org\" -DPACKAGE_URL=\"\" -DPACKAGE=\"sqlite\" -DVERSION=\"3.32.1\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_FDATASYNC=1 -DHAVE_USLEEP=1 -DHAVE_LOCALTIME_R=1 -DHAVE_GMTIME_R=1 -DHAVE_DECL_STRERROR_R=1 -DHAVE_STRERROR_R=1 -DHAVE_POSIX_FALLOCATE=1 -I. -I/bitcoin/depends/x86_64-linux-gnu/include -D_REENTRANT=1 -DSQLITE_THREADSAFE=1 -DSQLITE_OMIT_LOAD_EXTENSION=1 -DSQLITE_ENABLE_FTS4 -DSQLITE_ENABLE_FTS5 -DSQLITE_ENABLE_JSON1 -DSQLITE_ENABLE_RTREE -DSQLITE_ENABLE_GEOPOLY -pipe -O2 -MT sqlite3.lo -MD -MP -MF .deps/sqlite3.Tpo -c sqlite3.c  -fPIC -DPIC -o sqlite3.o
sqlite3.c: In function 'sqlite3SelectNew':
sqlite3.c:129016:10: warning: function may return address of local variable [-Wreturn-local-addr]
129016 |   return pNew;
       |          ^~~~
sqlite3.c:128976:10: note: declared here
128976 |   Select standin;
       |          ^~~~~~~
mv -f .deps/sqlite3.Tpo .deps/sqlite3.Plo
/bin/sh ./libtool  --tag=CC   --mode=link x86_64-linux-gnu-gcc -D_REENTRANT=1 -DSQLITE_THREADSAFE=1 -DSQLITE_OMIT_LOAD_EXTENSION=1 -DSQLITE_ENABLE_FTS4 -DSQLITE_ENABLE_FTS5 -DSQLITE_ENABLE_JSON1 -DSQLITE_ENABLE_RTREE -DSQLITE_ENABLE_GEOPOLY  -pipe -O2 -no-undefined -version-info 8:6:8 -L/bitcoin/depends/x86_64-linux-gnu/lib -o libsqlite3.la -rpath /bitcoin/depends/x86_64-linux-gnu/lib sqlite3.lo  -lm -lpthread 
libtool: link: x86_64-linux-gnu-gcc-ar cru .libs/libsqlite3.a  sqlite3.o
/bin/x86_64-linux-gnu-ar: `u' modifier ignored since `D' is the default (see `U')
libtool: link: x86_64-linux-gnu-gcc-ranlib .libs/libsqlite3.a
libtool: link: ( cd ".libs" && rm -f "libsqlite3.la" && ln -s "../libsqlite3.la" "libsqlite3.la" )
make[1]: Leaving directory '/bitcoin/depends/work/build/x86_64-linux-gnu/sqlite/3320100-67748321f63'
Staging sqlite...
make[1]: Entering directory '/bitcoin/depends/work/build/x86_64-linux-gnu/sqlite/3320100-67748321f63'
 /bin/mkdir -p '/bitcoin/depends/work/staging/x86_64-linux-gnu/sqlite/3320100-67748321f63/bitcoin/depends/x86_64-linux-gnu/lib'
 /bin/mkdir -p '/bitcoin/depends/work/staging/x86_64-linux-gnu/sqlite/3320100-67748321f63/bitcoin/depends/x86_64-linux-gnu/include'
 /bin/mkdir -p '/bitcoin/depends/work/staging/x86_64-linux-gnu/sqlite/3320100-67748321f63/bitcoin/depends/x86_64-linux-gnu/lib/pkgconfig'
 /bin/sh ./libtool   --mode=install /bin/install -c   libsqlite3.la '/bitcoin/depends/work/staging/x86_64-linux-gnu/sqlite/3320100-67748321f63/bitcoin/depends/x86_64-linux-gnu/lib'
 /bin/install -c -m 644 sqlite3.h sqlite3ext.h '/bitcoin/depends/work/staging/x86_64-linux-gnu/sqlite/3320100-67748321f63/bitcoin/depends/x86_64-linux-gnu/include'
 /bin/install -c -m 644 sqlite3.pc '/bitcoin/depends/work/staging/x86_64-linux-gnu/sqlite/3320100-67748321f63/bitcoin/depends/x86_64-linux-gnu/lib/pkgconfig'
libtool: install: /bin/install -c .libs/libsqlite3.lai /bitcoin/depends/work/staging/x86_64-linux-gnu/sqlite/3320100-67748321f63/bitcoin/depends/x86_64-linux-gnu/lib/libsqlite3.la
libtool: install: /bin/install -c .libs/libsqlite3.a /bitcoin/depends/work/staging/x86_64-linux-gnu/sqlite/3320100-67748321f63/bitcoin/depends/x86_64-linux-gnu/lib/libsqlite3.a
libtool: install: chmod 644 /bitcoin/depends/work/staging/x86_64-linux-gnu/sqlite/3320100-67748321f63/bitcoin/depends/x86_64-linux-gnu/lib/libsqlite3.a
libtool: install: x86_64-linux-gnu-gcc-ranlib /bitcoin/depends/work/staging/x86_64-linux-gnu/sqlite/3320100-67748321f63/bitcoin/depends/x86_64-linux-gnu/lib/libsqlite3.a
libtool: warning: remember to run 'libtool --finish /bitcoin/depends/x86_64-linux-gnu/lib'
make[1]: Leaving directory '/bitcoin/depends/work/build/x86_64-linux-gnu/sqlite/3320100-67748321f63'
Postprocessing sqlite...
Caching sqlite...
Extracting miniupnpc...
/bitcoin/depends/sources/miniupnpc-2.2.7.tar.gz: OK
Preprocessing miniupnpc...
patching file src/minisoap.c
patching file src/miniwget.c
patching file CMakeLists.txt
patching file src/win32_snprintf.h
Configuring miniupnpc...
-- The C compiler identification is GNU 10.5.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /bin/x86_64-linux-gnu-gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: /bitcoin/depends/work/build/x86_64-linux-gnu/miniupnpc/2.2.7-51dcaca5f17/build
Building miniupnpc...
make[1]: Entering directory '/bitcoin/depends/work/build/x86_64-linux-gnu/miniupnpc/2.2.7-51dcaca5f17/build'
make[1]: warning: -j12 forced in submake: resetting jobserver mode.
make[1]: *** No targets specified and no makefile found.  Stop.
make[1]: Leaving directory '/bitcoin/depends/work/build/x86_64-linux-gnu/miniupnpc/2.2.7-51dcaca5f17/build'
make: *** [funcs.mk:282: /bitcoin/depends/work/build/x86_64-linux-gnu/miniupnpc/2.2.7-51dcaca5f17/build/.stamp_built] Error 2
make: Leaving directory '/bitcoin/depends'
Build guix-linux failed with exit code 2
Fabien planned changes to this revision.Jul 31 2024, 19:57

Our cmake call sets the generator to ninja, so don't build with make

@bot guix-linux guix-osx guix-win

Tail of the build log:

-- Looking for __builtin_popcount
-- Looking for __builtin_popcount - found
-- Looking for __builtin_saddll_overflow
-- Looking for __builtin_saddll_overflow - found
-- Looking for __builtin_ssubll_overflow
-- Looking for __builtin_ssubll_overflow - found
-- Configuring done
-- Generating done
-- Build files have been written to: /bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/native
[3/19] Generating ../cargo/build/x86_64-unknown-linux-gnu/cxxbridge/chronik-bridge/src/ffi.rs.cc, ../cargo/build/x86_64-unknown-linux-gnu/cxxbridge/chronik_lib/src/ffi.rs.cc
Generating cxx bridge files
[4/11] Building native src/secp256k1/gen_context
ninja: no work to do.
[6/11] Running security-check.py on bitcoin-cli...
[7/11] Running security-check.py on bitcoin-tx...
[8/11] Running security-check.py on bitcoin-seeder...
[9/11] Running security-check.py on bitcoin-wallet...
[10/11] Running security-check.py on bitcoind...
[11/11] Running security-check.py on bitcoin-qt...
[0/19] cd /bitcoin/chronik/chronik-lib && /gnu/store/7ialc5c3b7if7qpr1gvzg88hinngiy7k-cmake-minimal-3.24.2/bin/cmake -E env CC_x86_64_unknown_linux_gnu=/gnu/store/hcd79kp23ignsdcf5rzq15m95vz085dd-gcc-cross-x86_64-linux-gnu-10.5.0/bin/x86_64-linux-gnu-gcc CXX_x86_64_unknown_linux_gnu=/gnu/store/hcd79kp23ignsdcf5rzq15m95vz085dd-gcc-cross-x86_64-linux-gnu-10.5.0/bin/x86_64-linux-gnu-g++ AR_x86_64_unknown_linux_gnu=/bin/x86_64-linux-gnu-ar CORROSION_BUILD_DIR=/bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/chronik CARGO_BUILD_RUSTC=/home/bitcoinabc/.rustup/toolchains/1.76.0-x86_64-unknown-linux-gnu/bin/rustc /home/bitcoinabc/.rustup/toolchains/1.76.0-x86_64-unknown-linux-gnu/bin/cargo rustc --lib --target=x86_64-unknown-linux-gnu --package chronik_lib --manifest-path /bitcoin/chronik/chronik-lib/Cargo.toml --target-dir /bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/./cargo/build --release --locked -- -Cdefault-linker-libraries=yes
warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`
note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest
note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest
note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions
    Finished release [optimized] target(s) in 0.09s
[1/19] Preparing native build...
-- Looking for __builtin_clz
-- Looking for __builtin_clz - found
-- Looking for __builtin_clzl
-- Looking for __builtin_clzl - found
-- Looking for __builtin_clzll
-- Looking for __builtin_clzll - found
-- Looking for __builtin_popcount
-- Looking for __builtin_popcount - found
-- Looking for __builtin_saddll_overflow
-- Looking for __builtin_saddll_overflow - found
-- Looking for __builtin_ssubll_overflow
-- Looking for __builtin_ssubll_overflow - found
-- Configuring done
-- Generating done
-- Build files have been written to: /bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/native
[2/19] Running utility command for _cargo-build_chronik_lib
[3/10] Building native src/secp256k1/gen_context
ninja: no work to do.
[5/10] Running symbol-check.py on bitcoin-tx...
[6/10] Running symbol-check.py on bitcoin-cli...
[7/10] Running symbol-check.py on bitcoin-seeder...
[8/10] Running symbol-check.py on bitcoin-wallet...
[9/10] Running symbol-check.py on bitcoind...
FAILED: src/CMakeFiles/symbol-check-bitcoind /bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src/CMakeFiles/symbol-check-bitcoind 
cd /bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src && /home/bitcoinabc/.guix-profile/bin/python3.10 /bitcoin/contrib/devtools/symbol-check.py /bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src/bitcoind
/bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src/bitcoind: libminiupnpc.so.17 is not in ALLOWED_LIBRARIES!
/bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src/bitcoind: failed LIBRARY_DEPENDENCIES
[10/10] Running symbol-check.py on bitcoin-qt...
FAILED: src/qt/CMakeFiles/symbol-check-bitcoin-qt /bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src/qt/CMakeFiles/symbol-check-bitcoin-qt 
cd /bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src/qt && /home/bitcoinabc/.guix-profile/bin/python3.10 /bitcoin/contrib/devtools/symbol-check.py /bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src/qt/bitcoin-qt
/bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src/qt/bitcoin-qt: libminiupnpc.so.17 is not in ALLOWED_LIBRARIES!
/bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src/qt/bitcoin-qt: failed LIBRARY_DEPENDENCIES
ninja: build stopped: subcommand failed.
Build guix-linux failed with exit code 1

Tail of the build log:

ld: warning: direct access in function 'void google::protobuf::internal::RepeatedPtrFieldBase::MergeFromInnerLoop<google::protobuf::RepeatedPtrField<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >::TypeHandler>(void**, void**, int, int)' from file 'src/qt/libbitcoin-qt-base.a(paymentrequest.pb.cc.o)' to global weak symbol 'void google::protobuf::internal::arena_destruct_object<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >(void*)' from file '/bitcoin/depends/x86_64-apple-darwin/lib/libprotobuf.a(arenastring.o)' means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings.
ld: warning: direct access in function 'PaymentServer::fetchPaymentACK(interfaces::Wallet&, SendCoinsRecipient const&, QByteArray)' from file 'src/qt/libbitcoin-qt-base.a(paymentserver.cpp.o)' to global weak symbol 'void google::protobuf::internal::arena_destruct_object<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >(void*)' from file '/bitcoin/depends/x86_64-apple-darwin/lib/libprotobuf.a(arenastring.o)' means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings.
[0/8] Preparing native build...
-- Looking for __builtin_clz
-- Looking for __builtin_clz - found
-- Looking for __builtin_clzl
-- Looking for __builtin_clzl - found
-- Looking for __builtin_clzll
-- Looking for __builtin_clzll - found
-- Looking for __builtin_popcount
-- Looking for __builtin_popcount - found
-- Looking for __builtin_saddll_overflow
-- Looking for __builtin_saddll_overflow - found
-- Looking for __builtin_ssubll_overflow
-- Looking for __builtin_ssubll_overflow - found
-- Configuring done
-- Generating done
-- Build files have been written to: /bitcoin/distsrc-87b0a4640229-x86_64-apple-darwin/native
[1/8] Building native src/secp256k1/gen_context
ninja: no work to do.
[3/8] Running security-check.py on bitcoin-cli...
[4/8] Running security-check.py on bitcoin-tx...
[5/8] Running security-check.py on bitcoin-seeder...
[6/8] Running security-check.py on bitcoin-wallet...
[7/8] Running security-check.py on bitcoind...
[8/8] Running security-check.py on bitcoin-qt...
[0/8] Preparing native build...
-- Looking for __builtin_clz
-- Looking for __builtin_clz - found
-- Looking for __builtin_clzl
-- Looking for __builtin_clzl - found
-- Looking for __builtin_clzll
-- Looking for __builtin_clzll - found
-- Looking for __builtin_popcount
-- Looking for __builtin_popcount - found
-- Looking for __builtin_saddll_overflow
-- Looking for __builtin_saddll_overflow - found
-- Looking for __builtin_ssubll_overflow
-- Looking for __builtin_ssubll_overflow - found
-- Configuring done
-- Generating done
-- Build files have been written to: /bitcoin/distsrc-87b0a4640229-x86_64-apple-darwin/native
[1/8] Building native src/secp256k1/gen_context
ninja: no work to do.
[3/8] Running symbol-check.py on bitcoin-cli...
[4/8] Running symbol-check.py on bitcoin-tx...
[5/8] Running symbol-check.py on bitcoin-seeder...
[6/8] Running symbol-check.py on bitcoin-wallet...
[7/8] Running symbol-check.py on bitcoind...
FAILED: src/CMakeFiles/symbol-check-bitcoind /bitcoin/distsrc-87b0a4640229-x86_64-apple-darwin/src/CMakeFiles/symbol-check-bitcoind 
cd /bitcoin/distsrc-87b0a4640229-x86_64-apple-darwin/src && /home/bitcoinabc/.guix-profile/bin/python3.10 /bitcoin/contrib/devtools/symbol-check.py /bitcoin/distsrc-87b0a4640229-x86_64-apple-darwin/src/bitcoind
libminiupnpc.17.dylib is not in ALLOWED_LIBRARIES!
/bitcoin/distsrc-87b0a4640229-x86_64-apple-darwin/src/bitcoind: failed DYNAMIC_LIBRARIES
[8/8] Running symbol-check.py on bitcoin-qt...
FAILED: src/qt/CMakeFiles/symbol-check-bitcoin-qt /bitcoin/distsrc-87b0a4640229-x86_64-apple-darwin/src/qt/CMakeFiles/symbol-check-bitcoin-qt 
cd /bitcoin/distsrc-87b0a4640229-x86_64-apple-darwin/src/qt && /home/bitcoinabc/.guix-profile/bin/python3.10 /bitcoin/contrib/devtools/symbol-check.py /bitcoin/distsrc-87b0a4640229-x86_64-apple-darwin/src/qt/BitcoinABC-Qt.app/Contents/MacOS/BitcoinABC-Qt
libminiupnpc.17.dylib is not in ALLOWED_LIBRARIES!
/bitcoin/distsrc-87b0a4640229-x86_64-apple-darwin/src/qt/BitcoinABC-Qt.app/Contents/MacOS/BitcoinABC-Qt: failed DYNAMIC_LIBRARIES
ninja: build stopped: subcommand failed.
Build guix-osx failed with exit code 1

Tail of the build log:

-- Looking for __builtin_clzll
-- Looking for __builtin_clzll - found
-- Looking for __builtin_popcount
-- Looking for __builtin_popcount - found
-- Looking for __builtin_saddll_overflow
-- Looking for __builtin_saddll_overflow - found
-- Looking for __builtin_ssubll_overflow
-- Looking for __builtin_ssubll_overflow - found
-- Configuring done
-- Generating done
-- Build files have been written to: /bitcoin/distsrc-87b0a4640229-x86_64-w64-mingw32/native
[3/17] Generating ../cargo/build/x86_64-pc-windows-gnu/cxxbridge/chronik-bridge/src/ffi.rs.cc, ../cargo/build/x86_64-pc-windows-gnu/cxxbridge/chronik_lib/src/ffi.rs.cc
Generating cxx bridge files
[4/10] Building native src/secp256k1/gen_context
ninja: no work to do.
[6/10] Running security-check.py on bitcoin-cli...
[7/10] Running security-check.py on bitcoin-tx...
[8/10] Running security-check.py on bitcoin-wallet...
[9/10] Running security-check.py on bitcoin-qt...
[10/10] Running security-check.py on bitcoind...
[0/17] cd /bitcoin/chronik/chronik-lib && /gnu/store/7ialc5c3b7if7qpr1gvzg88hinngiy7k-cmake-minimal-3.24.2/bin/cmake -E env CC_x86_64_pc_windows_gnu=/home/bitcoinabc/.guix-profile/bin/x86_64-w64-mingw32-gcc CXX_x86_64_pc_windows_gnu=/home/bitcoinabc/.guix-profile/bin/x86_64-w64-mingw32-g++ AR_x86_64_pc_windows_gnu=/home/bitcoinabc/.guix-profile/bin/x86_64-w64-mingw32-ar CORROSION_BUILD_DIR=/bitcoin/distsrc-87b0a4640229-x86_64-w64-mingw32/chronik CARGO_BUILD_RUSTC=/home/bitcoinabc/.rustup/toolchains/1.76.0-x86_64-unknown-linux-gnu/bin/rustc /home/bitcoinabc/.rustup/toolchains/1.76.0-x86_64-unknown-linux-gnu/bin/cargo rustc --lib --target=x86_64-pc-windows-gnu --package chronik_lib --manifest-path /bitcoin/chronik/chronik-lib/Cargo.toml --target-dir /bitcoin/distsrc-87b0a4640229-x86_64-w64-mingw32/./cargo/build --release --locked -- -Cdefault-linker-libraries=yes -Clink-args=--target=x86_64-w64-mingw32
warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`
note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest
note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest
note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions
    Finished release [optimized] target(s) in 0.10s
[1/17] Preparing native build...
-- Looking for __builtin_clz
-- Looking for __builtin_clz - found
-- Looking for __builtin_clzl
-- Looking for __builtin_clzl - found
-- Looking for __builtin_clzll
-- Looking for __builtin_clzll - found
-- Looking for __builtin_popcount
-- Looking for __builtin_popcount - found
-- Looking for __builtin_saddll_overflow
-- Looking for __builtin_saddll_overflow - found
-- Looking for __builtin_ssubll_overflow
-- Looking for __builtin_ssubll_overflow - found
-- Configuring done
-- Generating done
-- Build files have been written to: /bitcoin/distsrc-87b0a4640229-x86_64-w64-mingw32/native
[2/17] Running utility command for _cargo-build_chronik_lib
[3/9] Building native src/secp256k1/gen_context
ninja: no work to do.
[5/9] Running symbol-check.py on bitcoin-cli...
[6/9] Running symbol-check.py on bitcoin-tx...
[7/9] Running symbol-check.py on bitcoin-wallet...
[8/9] Running symbol-check.py on bitcoind...
FAILED: src/CMakeFiles/symbol-check-bitcoind /bitcoin/distsrc-87b0a4640229-x86_64-w64-mingw32/src/CMakeFiles/symbol-check-bitcoind 
cd /bitcoin/distsrc-87b0a4640229-x86_64-w64-mingw32/src && /home/bitcoinabc/.guix-profile/bin/python3.10 /bitcoin/contrib/devtools/symbol-check.py /bitcoin/distsrc-87b0a4640229-x86_64-w64-mingw32/src/bitcoind.exe
libminiupnpc.dll is not in ALLOWED_LIBRARIES!
/bitcoin/distsrc-87b0a4640229-x86_64-w64-mingw32/src/bitcoind.exe: failed DYNAMIC_LIBRARIES
[9/9] Running symbol-check.py on bitcoin-qt...
FAILED: src/qt/CMakeFiles/symbol-check-bitcoin-qt /bitcoin/distsrc-87b0a4640229-x86_64-w64-mingw32/src/qt/CMakeFiles/symbol-check-bitcoin-qt 
cd /bitcoin/distsrc-87b0a4640229-x86_64-w64-mingw32/src/qt && /home/bitcoinabc/.guix-profile/bin/python3.10 /bitcoin/contrib/devtools/symbol-check.py /bitcoin/distsrc-87b0a4640229-x86_64-w64-mingw32/src/qt/bitcoin-qt.exe
libminiupnpc.dll is not in ALLOWED_LIBRARIES!
/bitcoin/distsrc-87b0a4640229-x86_64-w64-mingw32/src/qt/bitcoin-qt.exe: failed DYNAMIC_LIBRARIES
ninja: build stopped: subcommand failed.
Build guix-win failed with exit code 1

Symbol check is now failing. Not sure why it previously didn't pick up libminiupnpc, but now it does.

  FAILED: src/qt/CMakeFiles/symbol-check-bitcoin-qt /bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src/qt/CMakeFiles/symbol-check-bitcoin-qt
21:14:08   cd /bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src/qt && /home/bitcoinabc/.guix-profile/bin/python3.10 /bitcoin/contrib/devtools/symbol-check.py /bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src/qt/bitcoin-qt
21:14:08   /bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src/qt/bitcoin-qt: libminiupnpc.so.17 is not in ALLOWED_LIBRARIES!
21:14:08   /bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src/qt/bitcoin-qt: failed LIBRARY_DEPENDENCIES
Fabien planned changes to this revision.Aug 1 2024, 07:19
In D16565#375083, @PiRK wrote:

Symbol check is now failing. Not sure why it previously didn't pick up libminiupnpc, but now it does.

  FAILED: src/qt/CMakeFiles/symbol-check-bitcoin-qt /bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src/qt/CMakeFiles/symbol-check-bitcoin-qt
21:14:08   cd /bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src/qt && /home/bitcoinabc/.guix-profile/bin/python3.10 /bitcoin/contrib/devtools/symbol-check.py /bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src/qt/bitcoin-qt
21:14:08   /bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src/qt/bitcoin-qt: libminiupnpc.so.17 is not in ALLOWED_LIBRARIES!
21:14:08   /bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src/qt/bitcoin-qt: failed LIBRARY_DEPENDENCIES

We use cmake_opts vs config_opts for core (which is not a good idea and is unused anyway, so I will change this in another diff). This causes the lib to build shared by default because it's missing -DUPNPC_BUILD_STATIC=ON and -DUPNPC_BUILD_SHARED=OFF.

@bot guix-linux guix-osx guix-win

Tail of the build log:

          ...bind-mounted in container to: /bitcoin/distsrc-418b157d729f-x86_64-w64-mingw32
      ...outputting in: '/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc/abc-ci-builds/guix-win/guix-results/x86_64-w64-mingw32'
          ...bind-mounted in container to: '/outdir-base/x86_64-w64-mingw32'
Updating channel 'guix' from Git repository at 'https://git.savannah.gnu.org/git/guix.git'...
hint: Consider installing the `glibc-locales' package and defining
`GUIX_LOCPATH', along these lines:

     guix install glibc-locales
     export GUIX_LOCPATH="$HOME/.guix-profile/lib/locale"

See the "Application Setup" section in the manual, for more info.

Required environment variables as seen inside the container:
    DIST_ARCHIVE_BASE: /outdir-base/dist-archive
    DISTNAME: bitcoin-418b157d729f
    HOST: x86_64-w64-mingw32
    SOURCE_DATE_EPOCH: 1675348147
    JOBS: 12
    DISTSRC: distsrc-418b157d729f-x86_64-w64-mingw32
    OUTDIR: /outdir-base/x86_64-w64-mingw32
make: Entering directory '/bitcoin/depends'
Extracting native_protobuf...
/bitcoin/depends/sources/protobuf-all-21.12.tar.gz: OK
Preprocessing native_protobuf...
Configuring native_protobuf...
CMake Warning:
  No source or binary directory provided.  Both will be assumed to be the
  same as the current working directory, but note that this warning will
  become a fatal error in future CMake releases.


-- The C compiler identification is GNU 10.5.0
-- The CXX compiler identification is GNU 10.5.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /bin/gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- 
-- 3.21.12.0
-- Performing Test protobuf_HAVE_LD_VERSION_SCRIPT
-- Performing Test protobuf_HAVE_LD_VERSION_SCRIPT - Success
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE  
-- Performing Test protobuf_HAVE_BUILTIN_ATOMICS
-- Performing Test protobuf_HAVE_BUILTIN_ATOMICS - Success
-- Configuring done
-- Generating done
-- Build files have been written to: /bitcoin/depends/work/build/x86_64-w64-mingw32/native_protobuf/21.12-987eafe5aef
Building native_protobuf...
ninja: error: loading 'build.ninja': No such file or directory
make: *** [funcs.mk:289: /bitcoin/depends/work/build/x86_64-w64-mingw32/native_protobuf/21.12-987eafe5aef/./.stamp_built] Error 1
make: Leaving directory '/bitcoin/depends'
Build guix-win failed with exit code 2

Tail of the build log:

          ...bind-mounted in container to: /bitcoin/distsrc-418b157d729f-x86_64-linux-gnu
      ...outputting in: '/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc/abc-ci-builds/guix-linux/guix-results/x86_64-linux-gnu'
          ...bind-mounted in container to: '/outdir-base/x86_64-linux-gnu'
Updating channel 'guix' from Git repository at 'https://git.savannah.gnu.org/git/guix.git'...
hint: Consider installing the `glibc-locales' package and defining
`GUIX_LOCPATH', along these lines:

     guix install glibc-locales
     export GUIX_LOCPATH="$HOME/.guix-profile/lib/locale"

See the "Application Setup" section in the manual, for more info.

Required environment variables as seen inside the container:
    DIST_ARCHIVE_BASE: /outdir-base/dist-archive
    DISTNAME: bitcoin-418b157d729f
    HOST: x86_64-linux-gnu
    SOURCE_DATE_EPOCH: 1675348147
    JOBS: 12
    DISTSRC: distsrc-418b157d729f-x86_64-linux-gnu
    OUTDIR: /outdir-base/x86_64-linux-gnu
make: Entering directory '/bitcoin/depends'
Extracting native_protobuf...
/bitcoin/depends/sources/protobuf-all-21.12.tar.gz: OK
Preprocessing native_protobuf...
Configuring native_protobuf...
CMake Warning:
  No source or binary directory provided.  Both will be assumed to be the
  same as the current working directory, but note that this warning will
  become a fatal error in future CMake releases.


-- The C compiler identification is GNU 10.5.0
-- The CXX compiler identification is GNU 10.5.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /bin/gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- 
-- 3.21.12.0
-- Performing Test protobuf_HAVE_LD_VERSION_SCRIPT
-- Performing Test protobuf_HAVE_LD_VERSION_SCRIPT - Success
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE  
-- Performing Test protobuf_HAVE_BUILTIN_ATOMICS
-- Performing Test protobuf_HAVE_BUILTIN_ATOMICS - Success
-- Configuring done
-- Generating done
-- Build files have been written to: /bitcoin/depends/work/build/x86_64-linux-gnu/native_protobuf/21.12-dd63523e52e
Building native_protobuf...
ninja: error: loading 'build.ninja': No such file or directory
make: *** [funcs.mk:289: /bitcoin/depends/work/build/x86_64-linux-gnu/native_protobuf/21.12-dd63523e52e/./.stamp_built] Error 1
make: Leaving directory '/bitcoin/depends'
Build guix-linux failed with exit code 2

Tail of the build log:

 /home/bitcoinabc/.guix-profile/bin/install -c -m 644 'bitcode_strip.1' '/bitcoin/depends/work/staging/x86_64-apple-darwin/native_cctools/2ef2e931cf641547eb8a68cfebde61003587c9fd-80a6ca1daa3/bitcoin/depends/x86_64-apple-darwin/native/share/man/man1/x86_64-apple-darwin-bitcode_strip.1'
 /home/bitcoinabc/.guix-profile/bin/install -c -m 644 'llvm-otool.1' '/bitcoin/depends/work/staging/x86_64-apple-darwin/native_cctools/2ef2e931cf641547eb8a68cfebde61003587c9fd-80a6ca1daa3/bitcoin/depends/x86_64-apple-darwin/native/share/man/man1/x86_64-apple-darwin-llvm-otool.1'
 /home/bitcoinabc/.guix-profile/bin/install -c -m 644 'nm-classic.1' '/bitcoin/depends/work/staging/x86_64-apple-darwin/native_cctools/2ef2e931cf641547eb8a68cfebde61003587c9fd-80a6ca1daa3/bitcoin/depends/x86_64-apple-darwin/native/share/man/man1/x86_64-apple-darwin-nm-classic.1'
 /home/bitcoinabc/.guix-profile/bin/install -c -m 644 'size-classic.1' '/bitcoin/depends/work/staging/x86_64-apple-darwin/native_cctools/2ef2e931cf641547eb8a68cfebde61003587c9fd-80a6ca1daa3/bitcoin/depends/x86_64-apple-darwin/native/share/man/man1/x86_64-apple-darwin-size-classic.1'
 /home/bitcoinabc/.guix-profile/bin/install -c -m 644 'otool-classic.1' '/bitcoin/depends/work/staging/x86_64-apple-darwin/native_cctools/2ef2e931cf641547eb8a68cfebde61003587c9fd-80a6ca1daa3/bitcoin/depends/x86_64-apple-darwin/native/share/man/man1/x86_64-apple-darwin-otool-classic.1'
 /home/bitcoinabc/.guix-profile/bin/install -c -m 644 'indr.1' '/bitcoin/depends/work/staging/x86_64-apple-darwin/native_cctools/2ef2e931cf641547eb8a68cfebde61003587c9fd-80a6ca1daa3/bitcoin/depends/x86_64-apple-darwin/native/share/man/man1/x86_64-apple-darwin-indr.1'
 /home/bitcoinabc/.guix-profile/bin/install -c -m 644 'checksyms.1' '/bitcoin/depends/work/staging/x86_64-apple-darwin/native_cctools/2ef2e931cf641547eb8a68cfebde61003587c9fd-80a6ca1daa3/bitcoin/depends/x86_64-apple-darwin/native/share/man/man1/x86_64-apple-darwin-checksyms.1'
 /home/bitcoinabc/.guix-profile/bin/install -c -m 644 'seg_addr_table.1' '/bitcoin/depends/work/staging/x86_64-apple-darwin/native_cctools/2ef2e931cf641547eb8a68cfebde61003587c9fd-80a6ca1daa3/bitcoin/depends/x86_64-apple-darwin/native/share/man/man1/x86_64-apple-darwin-seg_addr_table.1'
 /home/bitcoinabc/.guix-profile/bin/install -c -m 644 'check_dylib.1' '/bitcoin/depends/work/staging/x86_64-apple-darwin/native_cctools/2ef2e931cf641547eb8a68cfebde61003587c9fd-80a6ca1daa3/bitcoin/depends/x86_64-apple-darwin/native/share/man/man1/x86_64-apple-darwin-check_dylib.1'
 /home/bitcoinabc/.guix-profile/bin/install -c -m 644 'mtoc.1' '/bitcoin/depends/work/staging/x86_64-apple-darwin/native_cctools/2ef2e931cf641547eb8a68cfebde61003587c9fd-80a6ca1daa3/bitcoin/depends/x86_64-apple-darwin/native/share/man/man1/x86_64-apple-darwin-mtoc.1'
make[3]: Leaving directory '/bitcoin/depends/work/build/x86_64-apple-darwin/native_cctools/2ef2e931cf641547eb8a68cfebde61003587c9fd-80a6ca1daa3/cctools/man'
make[2]: Leaving directory '/bitcoin/depends/work/build/x86_64-apple-darwin/native_cctools/2ef2e931cf641547eb8a68cfebde61003587c9fd-80a6ca1daa3/cctools/man'
make[2]: Entering directory '/bitcoin/depends/work/build/x86_64-apple-darwin/native_cctools/2ef2e931cf641547eb8a68cfebde61003587c9fd-80a6ca1daa3/cctools'
make[3]: Entering directory '/bitcoin/depends/work/build/x86_64-apple-darwin/native_cctools/2ef2e931cf641547eb8a68cfebde61003587c9fd-80a6ca1daa3/cctools'
make[3]: Nothing to be done for 'install-exec-am'.
make[3]: Nothing to be done for 'install-data-am'.
make[3]: Leaving directory '/bitcoin/depends/work/build/x86_64-apple-darwin/native_cctools/2ef2e931cf641547eb8a68cfebde61003587c9fd-80a6ca1daa3/cctools'
make[2]: Leaving directory '/bitcoin/depends/work/build/x86_64-apple-darwin/native_cctools/2ef2e931cf641547eb8a68cfebde61003587c9fd-80a6ca1daa3/cctools'
make[1]: Leaving directory '/bitcoin/depends/work/build/x86_64-apple-darwin/native_cctools/2ef2e931cf641547eb8a68cfebde61003587c9fd-80a6ca1daa3/cctools'
Postprocessing native_cctools...
Caching native_cctools...
Extracting native_protobuf...
/bitcoin/depends/sources/protobuf-all-21.12.tar.gz: OK
Preprocessing native_protobuf...
Configuring native_protobuf...
CMake Warning:
  No source or binary directory provided.  Both will be assumed to be the
  same as the current working directory, but note that this warning will
  become a fatal error in future CMake releases.


-- The C compiler identification is GNU 10.5.0
-- The CXX compiler identification is GNU 10.5.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /home/bitcoinabc/.guix-profile/bin/gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /home/bitcoinabc/.guix-profile/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- 
-- 3.21.12.0
-- Performing Test protobuf_HAVE_LD_VERSION_SCRIPT
-- Performing Test protobuf_HAVE_LD_VERSION_SCRIPT - Success
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE  
-- Performing Test protobuf_HAVE_BUILTIN_ATOMICS
-- Performing Test protobuf_HAVE_BUILTIN_ATOMICS - Success
-- Configuring done
-- Generating done
-- Build files have been written to: /bitcoin/depends/work/build/x86_64-apple-darwin/native_protobuf/21.12-96e596467af
Building native_protobuf...
ninja: error: loading 'build.ninja': No such file or directory
make: *** [funcs.mk:289: /bitcoin/depends/work/build/x86_64-apple-darwin/native_protobuf/21.12-96e596467af/./.stamp_built] Error 1
make: Leaving directory '/bitcoin/depends'
Build guix-osx failed with exit code 2
Fabien planned changes to this revision.Aug 1 2024, 09:01

@bot guix-linux guix-osx guix-win

This revision is now accepted and ready to land.Aug 1 2024, 10:14
This revision was automatically updated to reflect the committed changes.