Page MenuHomePhabricator

[chronik] Remove the legacy NNG tests
ClosedPublic

Authored by Fabien on Aug 1 2024, 19:01.

Details

Reviewers
tobias_ruck
Group Reviewers
Restricted Project
Commits
rABC919430aa3058: [chronik] Remove the legacy NNG tests
Summary

These tests rely on a live NNG server which has been shut down and are no longer working. Since we are deprectating NNG support, just remove the tests.

Test Plan
./contrib/teamcity/build-configurations.py chronik-client-tests

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Aug 1 2024, 19:01
tobias_ruck added inline comments.
modules/chronik-client/test/test.ts
109 ↗(On Diff #48999)

should we leave the code that doesn't require instances (for now?)

modules/chronik-client/test/test.ts
109 ↗(On Diff #48999)

I considered this but the class will be reworked and no longer take a single url (but an array instead) so it will add more work for little benefit

can't say no to this much removed code 🤷🏼‍♂️

This revision is now accepted and ready to land.Aug 1 2024, 19:31
This revision was automatically updated to reflect the committed changes.