StakeContenderId will enable the node to poll for potential stake winners (as a new CInv type). This will further enable pre-consensus on staking rewards to ensure that nodes validate the same winner set even if some proofs are missing from some nodes' proof sets.
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Project - Commits
- rABC5ad50cf4eb85: [avalanche] Introduce StakeContenderId
ninja check-avalanche
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- sw-id
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 29972 Build 59478: Build Diff build-diff · build-without-wallet · build-clang-tidy · lint-circular-dependencies · build-clang · build-debug Build 59477: arc lint + arc unit
Event Timeline
| src/avalanche/stakecontender.h | ||
|---|---|---|
| 8 ↗ | (On Diff #49167) | remove |
| 9 ↗ | (On Diff #49167) | remove |
| 10 ↗ | (On Diff #49167) | remove |
| 23 ↗ | (On Diff #49167) | Prefer strong typing so we don't do implicit conversions |
| 26 ↗ | (On Diff #49167) | Why using the payout script here instead of the proofid ? proofid is the source of uniqueness |
Comment Actions
- cleanups
- strongly type StakeContenderId
- switch to blockhash + proofid instead of blockhash + payoutscript since this could be more versatile down the road
- streamlined implementation a bit, which eliminated stakecontender.cpp
| src/avalanche/stakecontender.h | ||
|---|---|---|
| 25 | needs to include hash.h for the Hash function | |