Update token-server to use current nomenclature and not legacy ChronikClientNode
Details
Details
- Reviewers
emack - Group Reviewers
Restricted Project - Commits
- rABC9be57e9f260a: [token-server] Replace references to ChronikClientNode with ChronikClient
npm test, grep -r ChronikClientNode . and no output
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- token-server-no-node
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 30002 Build 59538: Build Diff token-server-tests Build 59537: arc lint + arc unit
Event Timeline
Comment Actions
Just so I'm understanding this correctly, there's no need to update package.json here to pick up the new chronik-client with the deprecated legacy ChronikClientNode constructor? Because it's on a relative path? But external apps using the chronik-client will right?
Comment Actions
there's no need to update package.json here to pick up the new chronik-client with the deprecated legacy ChronikClientNode constructor? Because it's on a relative path?
Correct -- tho also this app would still work with that relative import without this change, since chronik-client aliases both to the in-node class now.
But external apps using the chronik-client will right?
Well, the latest monorepo updates to chronik-client have not been published yet. So, currently there is no required action for anyone using chronik-client as an npm module.
The way the codebase is right now -- if chronik-client is published -- both ChronikClientNode and ChronikClient are acceptable aliases for an in-node chronik server. However, all of the types that ended with InNode have been updated ... so if those are referenced anywhere, that will need to be corrected before updating to 1.0.0.
...debating just dropping support for the ChronikClientNode import but it's probably harmless enough to keep in.
Comment Actions
if you are testing it locally, you will have to build chronik-client in the appropriate directory
cd modules/chronik-client npm run build cd ../../apps/token-server npm test npm run build